Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 133262 - sylpheed-claws-etpan-privacy-0.13 does not configure with -Wl,--as-needed
Summary: sylpheed-claws-etpan-privacy-0.13 does not configure with -Wl,--as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Marius Mauch (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2006-05-13 22:09 UTC by Sascha G.
Modified: 2006-10-03 11:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sylpheed-claws-etpan-privacy-0.13-asneeded.patch (sylpheed-claws-etpan-privacy-0.13-asneeded.patch,501 bytes, patch)
2006-05-13 22:10 UTC, Sascha G.
Details | Diff
ebuild patch (scep.ebuild.diff,818 bytes, patch)
2006-05-13 22:11 UTC, Sascha G.
Details | Diff
sylpheed-claws-etpan-privacy-0.13-as-needed.patch (sylpheed-claws-etpan-privacy-0.13-as-needed.patch,554 bytes, patch)
2006-05-20 01:15 UTC, Sascha G.
Details | Diff
sylpheed-claws-etpan-privacy-0.13.ebuild.patch (ebuild.patch,856 bytes, patch)
2006-05-20 01:16 UTC, Sascha G.
Details | Diff
sylpheed-claws-etpan-privacy-0.13.ebuild.patch (EBUILD.PATCH,842 bytes, patch)
2006-05-24 04:28 UTC, Sascha G.
Details | Diff
sylpheed-claws-etpan-privacy-0.15.1-as-needed.patch (sylpheed-claws-etpan-privacy-0.15.1-as-needed.patch,574 bytes, patch)
2006-06-25 12:01 UTC, Sascha G.
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha G. 2006-05-13 22:09:23 UTC
mail-client/sylpheed-claws-etpan-privacy aborts configure stage with LDFLAGS="-Wl,--as-needed":

checking for libetpan-config... /usr/bin/libetpan-config
checking libetpan/libetpan.h usability... yes
checking libetpan/libetpan.h presence... yes
checking for libetpan/libetpan.h... yes
checking whether libetpan-config hints compiles and links fine... no
configure: error: libetpan support required

With the attached patches it configures, builds & runs fine.
Comment 1 Sascha G. 2006-05-13 22:10:52 UTC
Created attachment 86728 [details, diff]
sylpheed-claws-etpan-privacy-0.13-asneeded.patch
Comment 2 Sascha G. 2006-05-13 22:11:28 UTC
Created attachment 86729 [details, diff]
ebuild patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-05-19 17:55:46 UTC
The patch is not solving the problem at all. What it does is changing the linking order in the wrong way (look at http://www.gentoo.org/proj/en/qa/asneeded.xml for the right ordering of parameters). Also it touches configure, that should never be done, you should patch configure.in or configure.ac depending on what the package is using.
Comment 4 Sascha G. 2006-05-19 18:08:23 UTC
(In reply to comment #3)
> The patch is not solving the problem at all. What it does is changing the
> linking order in the wrong way (look at
> http://www.gentoo.org/proj/en/qa/asneeded.xml for the right ordering of
> parameters). Also it touches configure, that should never be done, you should
> patch configure.in or configure.ac depending on what the package is using.

This patch only helps with a small problem with a test in the configure script, everything else works fine.
But I will look into what you said and try to come up with a better patch when I find some time.
Thanks for the input.
Comment 5 Sascha G. 2006-05-20 01:13:18 UTC
(In reply to comment #3)
> The patch is not solving the problem at all. What it does is changing the
> linking order in the wrong way (look at
> http://www.gentoo.org/proj/en/qa/asneeded.xml for the right ordering of
> parameters). Also it touches configure, that should never be done, you should
> patch configure.in or configure.ac depending on what the package is using.

I have been looking into this (with open eyes now :-)) ) and I can see that you are of course completely right.
Hopefully, I got it right this time.
Again, thanks for the input, it helped me learn a great deal about autoconf.
Comment 6 Sascha G. 2006-05-20 01:15:06 UTC
Created attachment 87101 [details, diff]
sylpheed-claws-etpan-privacy-0.13-as-needed.patch
Comment 7 Sascha G. 2006-05-20 01:16:45 UTC
Created attachment 87102 [details, diff]
sylpheed-claws-etpan-privacy-0.13.ebuild.patch
Comment 8 Sascha G. 2006-05-24 04:28:54 UTC
Created attachment 87378 [details, diff]
sylpheed-claws-etpan-privacy-0.13.ebuild.patch

no elibtoolize necessary
Comment 9 Marius Mauch (RETIRED) gentoo-dev 2006-06-24 21:29:45 UTC
Diego: can you take a look at this again and let me know if it's proper?
Sascha: please send this upstream as well.
Comment 10 Sascha G. 2006-06-25 12:01:07 UTC
Created attachment 90131 [details, diff]
sylpheed-claws-etpan-privacy-0.15.1-as-needed.patch

Updated patch, ebuild patch is basically the same.
I'll go upstream with this in a few minutes.
Comment 12 Sascha G. 2006-07-01 14:01:40 UTC
(In reply to comment #10)
> Created an attachment (id=90131) [edit]
> sylpheed-claws-etpan-privacy-0.15.1-as-needed.patch

This has been accepted upstream.
Comment 13 Marius Mauch (RETIRED) gentoo-dev 2006-08-13 05:21:09 UTC
added to CVS some time ago
Comment 14 Sascha G. 2006-09-01 01:19:47 UTC
(In reply to comment #13)
> added to CVS some time ago

Upstream, yes, in version 0.15.2. But neither the fix nor this version are in Gentoo portage yet.
Comment 15 Sascha G. 2006-10-03 11:37:09 UTC
Now it's done (version 0.15.3).