[ebuild R ] kde-base/kolf-3.5.2 USE="arts -debug kdeenablefinal -xinerama" 0 kB The arts use flag is there because of kde.eclass. However, kolf does not work without arts - that's why there is the check in pkg_setup(). There are quite a few packages with the same check in the tree - some simple grep-foo shows /usr/portage/kde-base $ grep "needs the USE" */*.ebuild | cut -d '/' -f 1 | uniq artsplugin-akode artsplugin-audiofile artsplugin-mpeglib artsplugin-mpg123 artsplugin-xine kaboodle kasteroids kbounce kdemultimedia-arts kolf krec noatun I think, kde.eclass should handle this. Will attach a patch.
Created attachment 86691 [details, diff] kde.eclass-fix-arts-not-optional.patch Patch against kde.eclass
Created attachment 86692 [details, diff] kolf-patch Patch against kolf.
The other patches would look exactly the same. Would you prefer one patch for each package or one big patch for all of them?
Sorry, wrong category.
arts must die...
(In reply to comment #5) > arts must die... > Yeah, but in the meantime, we can make it's last hours as painless as possible ;)
*** Bug 134682 has been marked as a duplicate of this bug. ***
Created attachment 87806 [details, diff] kde.eclass-fix-arts-not-optional.patch Updated the patch to latest CVS. (The old patch still applies, just a lame excuse to generate some bugzilla spam :P)
I think I proposed such a change in the past to kde@g.o alias, about the time when I rewrote the kdeenablefinal support. Anyway, I'll be working on this tomorrow most likely :)
*** Bug 134825 has been marked as a duplicate of this bug. ***
Okay the eclass patch is merged, now I'll try to fix the ebuilds that might require this. I changed the name from ARTS_IS_OPTIONAL="no" to ARTS_REQUIRED="yes", I dislike inverse selections :)
Okay all packages in kde-base are fixed, I'll grep the tree to see if there is something else to fix (probably). Thanks again.
Any reason for [ ... ] instead of [[ ... ]] ? Now anything not needing arts spits out a warning >>> Emerging (1 of 2) kde-base/kopete-3.5.2 to / >>> checking ebuild checksums ;-) >>> checking auxfile checksums ;-) >>> checking miscfile checksums ;-) >>> checking kdenetwork-3.5.2.tar.bz2 ;-) /var/cvs/gentoo-x86/eclass/kde.eclass: line 58: [: ==: unary operator expected since [ == yes ] is obviously incorrect.
Harald, I fixed that a few minutes after the first commit :)
(In reply to comment #11) > Okay the eclass patch is merged, now I'll try to fix the ebuilds that might > require this. > I changed the name from ARTS_IS_OPTIONAL="no" to ARTS_REQUIRED="yes", I dislike > inverse selections :) > Fine with me :) Thanks.
The change is wrong. We have packages that depending on aRts, optionally depeding on aRts and those that do not need aRts at all. That makes three cases to toggle between, not two.
And the problem this bug report was for report is fixed. The other case I already taken in consideration _but_ right now I'm not sure on the course to handle it, because if i don't pass --without-arts it links to arts anyway if found, so dropping the arts useflag would be an error for them just yet. Which mean the change is _incomplete_, not wrong.
*sigh* Yes, Diego "half-assed solutions" Petteno.
No, it is Diego "I still have only 24 hours a day and I take care of other things during the time as I need a job to pay my bills" Petten
No, it is Diego "I still have only 24 hours a day and I take care of other things during the time as I need a job to pay my bills" Pettenò. Did I ever said I wasn't going on working on it? I *do* have the code ready locally, I just want to test it out before committing it, as I had the code for the ARTS_REQUIRED="no" support ready about two months ago and nobody cared to say 'a' about it.
(In reply to comment #19) > No, it is Diego "I still have only 24 hours a day and I take care of other > things during the time as I need a job to pay my bills" Petten
(In reply to comment #19) > No, it is Diego "I still have only 24 hours a day and I take care of other > things during the time as I need a job to pay my bills" Pettenò. Just like everyone else. I'm just a bit pissed that you don't discuss it on kde@gentoo.org before you do such changes. That the arts use flag has been wrongy set globally was done intentionally (predating your dev status) both because of the lack of proper use dependencies and lack of enough mantainers to do the dauting task of updating all packages quickly. Regarding ARTS_REQUIRED="no/yes" and configure flags, I don't see what your problem is. no := --without-arts , yes := --with-arts, unset := $(use_with arts) and you're through with it.
