Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 131020 - audacious-crystality-0.92.ebuild
Summary: audacious-crystality-0.92.ebuild
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-23 13:37 UTC by Szary
Modified: 2006-04-30 14:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
audacious-crystality-0.92.ebuild (audacious-crystality-0.92.ebuild,701 bytes, text/plain)
2006-04-23 13:39 UTC, Szary
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szary 2006-04-23 13:37:03 UTC
Wroted ebuild for this great Audacious plugin:

# Copyright 1999-2005 Gentoo Foundation 
# Distributed under the terms of the GNU General Public License v2 

inherit eutils 
IUSE="" 
S=${WORKDIR}/crystality-plugin-${PV}-aud
DESCRIPTION="Attempts to improve sound output quality" 
SRC_URI="http://mitglied.lycos.de/mldoering/audacious-plugins/crystality-plugin-${PV}-aud.tar.bz2" 
HOMEPAGE="http://mitglied.lycos.de/mldoering/audacious-plugins/" 
SLOT="0" 
LICENSE="GPL-2" 
KEYWORDS="~alpha ~amd64 ~ppc ppc64 x86" 
DEPEND="media-sound/audacious" 

src_unpack() { 
unpack ${A} 
cd ${S}
}

src_compile() {
	emake || die "emake failed"
}

src_install () { 
exeinto /usr/lib/audacious/Effect/
doexe ${S}/libcrystality.so
dodoc COPYING ChangeLog README
}
Comment 1 Szary 2006-04-23 13:39:05 UTC
Created attachment 85303 [details]
audacious-crystality-0.92.ebuild
Comment 2 Tony Vroon gentoo-dev 2006-04-30 14:43:20 UTC
The src_unpack that you have specified is equal to the default, please remove it.  As you are not using any functions provided by the eutils eclass, feel free to drop the "inherit eutils" as well. 
All KEYWORDS should be prefixed with ~, and I must ask if you have really tested the package on all those architectures. Only specify the architectures on which you can vouch for the stability of the package.
You have deleted the Header line, this will have to be added back. Also, please update the copyright as it has been 2006 for a while.
As a final remark, please use tabs in src_install. Once these issues are addressed, feel free to reopen the bug and I will test your ebuild.