129778 – improved patch for games-arcade/tomatoes-1.55-r1

Bug 129778 - improved patch for games-arcade/tomatoes-1.55-r1

Summary: improved patch for games-arcade/tomatoes-1.55-r1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	AMD64 Linux

Importance:	High normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-04-13 01:57 UTC by whereami
Modified:	2006-09-01 16:47 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
fixes strings in functions for locating config file (tomatoes-1.55-config_strings.patch,1.74 KB, patch) 2006-04-13 02:02 UTC, whereami	Details \| Diff
tested patch (tomatoes-1.55-config_strings.patch,2.51 KB, patch) 2006-04-13 02:36 UTC, whereami	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description whereami 2006-04-13 01:57:05 UTC

The patch added in bug #116629 works, but it's a little sloppy, since it creates a small memory leak. I have a slightly more invasive patch that fixes the problem correctly.

Also, I suggest marking the original 1.55 ~amd64, or even -amd64, since it just doesn't work on a second run without removing the config.

Comment 1 whereami 2006-04-13 02:02:40 UTC

Created attachment 84537 [details, diff]
fixes strings in functions for locating config file

Comment 2 whereami 2006-04-13 02:36:59 UTC

Created attachment 84538 [details, diff]
tested patch

I forgot to actually test the patch before submitting it... Must be late. This one is tested.

Comment 3 Tupone Alfredo gentoo-dev

2006-09-01 16:47:13 UTC

Memory leak should be fixed in games-arcade/tomatoes-1.55-r2
Patch is not exactly the one you posted, but thanks for pointing out the problem