Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 128937 - dev-libs/libusb: don't redefine usb_hid_descriptor
Summary: dev-libs/libusb: don't redefine usb_hid_descriptor
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Alastair Tse (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-05 10:37 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-24 14:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libusb-0.1.12-fbsd-hid.patch (libusb-0.1.12-fbsd-hid.patch,2.42 KB, patch)
2006-04-05 10:45 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Ebuild patch (libusb-ebuild.patch,968 bytes, patch)
2006-04-05 13:00 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-05 10:37:22 UTC
The attached patch (that I've submitted upstream too) checks for usb_hid_descriptor struct presence before defining it, so that it doesn't override the system's definition.
This is needed for SDL to detect usb support (and thus joysticks) correctly.

The attached patch is over libusb-0.1.12, should work with 0.1.11 too, but as it would require a version bump, it would help if it was added with the version bump.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-05 10:45:02 UTC
Created attachment 83994 [details, diff]
libusb-0.1.12-fbsd-hid.patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-05 13:00:58 UTC
Created attachment 84016 [details, diff]
Ebuild patch

This patch to the ebuild adds a bit of verbosity to the || die during src_install, as I was a bit surprised when it failed, and adds a missing dependency over docbook-dsssl-stylesheets without which I can't actually build the documentation at all.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-18 11:40:07 UTC
This would really be needed soon.

Alastair, if you can't commit this in about 10 days, I'll go on and handle it in the mean time (taking the pieces if something breaks of course).
Comment 4 Alastair Tse (RETIRED) gentoo-dev 2006-04-24 14:29:41 UTC
in 0.1.12. thanks for the patch.