Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 128760 - Series patches for freetype 2.1.10
Summary: Series patches for freetype 2.1.10
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: foser (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-04 05:05 UTC by Lin Hao-jie
Modified: 2006-04-05 06:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Freetype 2.1.10 Patches (freetype2-2.1.10-patches.tar.gz,20.79 KB, patch)
2006-04-04 05:06 UTC, Lin Hao-jie
Details | Diff
bugzilla-97202-fix-x-crash.patch (bugzilla-97202-fix-x-crash.patch,353 bytes, patch)
2006-04-04 05:10 UTC, Lin Hao-jie
Details | Diff
bugzilla-157441-autofit-cjk-cvs.patch (bugzilla-157441-autofit-cjk-cvs.patch,93.77 KB, patch)
2006-04-04 05:11 UTC, Lin Hao-jie
Details | Diff
bugzilla-158156-memory-leak.patch (bugzilla-158156-memory-leak.patch,484 bytes, patch)
2006-04-04 05:11 UTC, Lin Hao-jie
Details | Diff
bugzilla-158573-fix-orientation-detection.patch (bugzilla-158573-fix-orientation-detection.patch,2.14 KB, patch)
2006-04-04 05:12 UTC, Lin Hao-jie
Details | Diff
bugzilla-159166-reduce-embolden-distance.patch (bugzilla-159166-reduce-embolden-distance.patch,443 bytes, patch)
2006-04-04 05:12 UTC, Lin Hao-jie
Details | Diff
enable_ft_optimize_memory.patch (enable_ft_optimize_memory.patch,480 bytes, patch)
2006-04-04 05:13 UTC, Lin Hao-jie
Details | Diff
freetype2-bitmap-foundry.patch (freetype2-bitmap-foundry.patch,1.81 KB, patch)
2006-04-04 05:13 UTC, Lin Hao-jie
Details | Diff
freetype-2.1.10-cvsfixes.patch (freetype-2.1.10-cvsfixes.patch,34.87 KB, patch)
2006-04-05 04:07 UTC, Lin Hao-jie
Details | Diff
freetype-2.1.10-xorgfix.patch (freetype-2.1.10-xorgfix.patch,508 bytes, patch)
2006-04-05 04:07 UTC, Lin Hao-jie
Details | Diff
freetype-2.1.10-fixautofit.patch (freetype-2.1.10-fixautofit.patch,511 bytes, patch)
2006-04-05 04:08 UTC, Lin Hao-jie
Details | Diff
freetype-2.1.10-memleak.patch (freetype-2.1.10-memleak.patch,484 bytes, patch)
2006-04-05 04:09 UTC, Lin Hao-jie
Details | Diff
freetype-2.1.10-fixkerning.patch (freetype-2.1.10-fixkerning.patch,502 bytes, patch)
2006-04-05 04:10 UTC, Lin Hao-jie
Details | Diff
freetype-2.1.10-fixaliasing.patch (freetype-2.1.10-fixaliasing.patch,727 bytes, patch)
2006-04-05 04:10 UTC, Lin Hao-jie
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lin Hao-jie 2006-04-04 05:05:00 UTC
Patches are from SUSE.

Bugzilla #158573: fix corrupt embolden glyphs issue for CJK fonts.
Bugzilla #159166: reduce embolden strength to get better rendering effect.
Bugzilla #158156: fix a memory leak 
Bugzilla #157441: use a patch from upstream CVS which renders slightly better.
Bugzilla #157441: FZSongTi.ttf contains a lot more (CJK)-glyphs
  than most other fonts, therefore we have to expand the cjk range
  in Takashi Iwai's "ft2-autofit-02-cjk.diff" to render these
  glyphs correctly as well.

bugzilla-97202:fix-x-crash
enable_ft_optimize_memory.patch
Comment 1 Lin Hao-jie 2006-04-04 05:06:54 UTC
Created attachment 83876 [details, diff]
Freetype 2.1.10 Patches
Comment 2 Lin Hao-jie 2006-04-04 05:10:22 UTC
Created attachment 83877 [details, diff]
bugzilla-97202-fix-x-crash.patch
Comment 3 Lin Hao-jie 2006-04-04 05:11:22 UTC
Created attachment 83878 [details, diff]
bugzilla-157441-autofit-cjk-cvs.patch
Comment 4 Lin Hao-jie 2006-04-04 05:11:49 UTC
Created attachment 83879 [details, diff]
bugzilla-158156-memory-leak.patch
Comment 5 Lin Hao-jie 2006-04-04 05:12:26 UTC
Created attachment 83880 [details, diff]
bugzilla-158573-fix-orientation-detection.patch
Comment 6 Lin Hao-jie 2006-04-04 05:12:55 UTC
Created attachment 83881 [details, diff]
bugzilla-159166-reduce-embolden-distance.patch
Comment 7 Lin Hao-jie 2006-04-04 05:13:26 UTC
Created attachment 83883 [details, diff]
enable_ft_optimize_memory.patch
Comment 8 Lin Hao-jie 2006-04-04 05:13:55 UTC
Created attachment 83885 [details, diff]
freetype2-bitmap-foundry.patch
Comment 9 foser (RETIRED) gentoo-dev 2006-04-05 00:31:18 UTC
fyi we don't integrate patches b/c other distros add them. There is little basis to act that way. Some of these issues are covered in other bugs, others have no relevance to us and again others are just too extensive for us to maintain.
Comment 10 Lin Hao-jie 2006-04-05 04:05:51 UTC
What about these Patches , These are from Fedora or Mandriva.

Both Fedora and Mandriva apply the patches in their Freetype2.1.10 package.
Most of them are cvs-fix,So I think it will not need spend so much to maintain them

In fact, some of SUSE's patches are also cvs-fix, those are same as Fedora and Mandriva's
 
 
Patch0:mostly embolding fix (CVS)		
freetype-2.1.10-cvsfixes.patch

Patch1:		
freetype-2.1.10-xorgfix.patch

Patch2:fix autofit render setup (CVS)		
freetype-2.1.10-fixautofit.patch

Patch3:fix memleak (CVS)		
freetype-2.1.10-memleak.patch

Patch4:fix kerning wrongly disabled (CVS)
freetype-2.1.10-fixkerning.patch

Patch5:fix bad anti-aliasing (CVS)
freetype-2.1.10-fixaliasing.patch
Comment 11 Lin Hao-jie 2006-04-05 04:07:14 UTC
Created attachment 83955 [details, diff]
freetype-2.1.10-cvsfixes.patch
Comment 12 Lin Hao-jie 2006-04-05 04:07:59 UTC
Created attachment 83956 [details, diff]
freetype-2.1.10-xorgfix.patch
Comment 13 Lin Hao-jie 2006-04-05 04:08:42 UTC
Created attachment 83957 [details, diff]
freetype-2.1.10-fixautofit.patch
Comment 14 Lin Hao-jie 2006-04-05 04:09:23 UTC
Created attachment 83958 [details, diff]
freetype-2.1.10-memleak.patch
Comment 15 Lin Hao-jie 2006-04-05 04:10:09 UTC
Created attachment 83959 [details, diff]
freetype-2.1.10-fixkerning.patch
Comment 16 Lin Hao-jie 2006-04-05 04:10:56 UTC
Created attachment 83960 [details, diff]
freetype-2.1.10-fixaliasing.patch
Comment 17 foser (RETIRED) gentoo-dev 2006-04-05 04:26:55 UTC
you really didn't get my comment did you ?

I am aware of other distros and their patches. Whats the difference between providing a cvs ebuild and a stable version patched with every single addition from cvs ? We don't do the first, so why do the latter if there is no real need.

And what bothers me most is that you don't even look at the patches or know what they do, you attached certain patches twice.
Comment 18 Lin Hao-jie 2006-04-05 06:12:32 UTC
Sorry for my bothers.

retrieving revision 1.27
retrieving revision 1.30
diff -u -p -r1.27 -r1.30
--- freetype2/src/base/ftsynth.c	30 May 2005 07:54:20 -0000	1.27
+++ freetype2/src/base/ftsynth.c	23 Jun 2005 20:31:48 -0000	1.30
@@ -81,13 +81,16 @@
 
     /* some reasonable strength */
     xstr = FT_MulFix( face->units_per_EM,
-                      face->size->metrics.y_scale ) / 42;
+                      face->size->metrics.y_scale ) / 24;
     ystr = xstr;
 
     if ( slot->format == FT_GLYPH_FORMAT_OUTLINE )
     {
       error = FT_Outline_Embolden( &slot->outline, xstr );
-      xstr = xstr * 4;  /* according to the documentation */
+
+      /* this is more than enough for most glyphs;                         */
+      /* if you need accurate values, you have to call FT_Outline_Get_CBox */
+      xstr = xstr * 2;
       ystr = xstr;
     }
     else if ( slot->format == FT_GLYPH_FORMAT_BITMAP )
@@ -122,8 +125,8 @@
     /* modify the metrics accordingly */
     if ( !error )
     {
+      /* assume the layout is horizontal */
       slot->advance.x += xstr;
-      slot->advance.y += ystr;
 
       slot->metrics.width        += xstr;
       slot->metrics.height       += ystr;


contain in "freetype-2.1.10-cvsfixes.patch" can fix embold fonts issue.

wrong display
http://img98.imageshack.us/my.php?image=screenshot17ob.png

correct display
http://img351.imageshack.us/my.php?image=screenshot27hp.png

Hope can do something on this issue.