Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 128598 - emerge -pqv should display USE flags
Summary: emerge -pqv should display USE flags
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 136244
  Show dependency tree
 
Reported: 2006-04-02 21:53 UTC by David Watzke
Modified: 2006-08-06 04:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against emerge-2.1.1_pre4-r2 (emerge_verbose_quiet.patch,840 bytes, patch)
2006-08-05 05:20 UTC, David-John Miller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Watzke 2006-04-02 21:53:46 UTC
Well.. we've got this...

$ emerge -pq virtual/pager
[ebuild   R   ] sys-apps/less-394

$ emerge -pqv virtual/pager
[ebuild   R   ] sys-apps/less-394

but it's same :) and -v is (in this case) functionless, but why? IMHO it should give (with -v)

[ebuild   R   ] sys-apps/less-394  USE="unicode"

or

[ebuild   R   ] sys-apps/less-394  USE="unicode" 0 kB

What do you think about that?
Comment 1 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-04-02 21:57:21 UTC
I think --quiet overrides verbose.
Comment 2 David Watzke 2006-04-02 22:05:20 UTC
And that's good or bad? I don't know, but I think that this would be better. Sure, only if it's possible and if it won't collide with something other...
Comment 3 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-04-02 22:59:22 UTC
Well in the code we have four 'states'.

Verbose is on/Quiet is on
Verbose is off/Quiet is on
Verbose is on/Quiet is off
Verbose is off/Quiet is off

There are pieces of "verbose" output that are not...'guarded' by a quiet.  Meaning that in some cases emerge -vq will print verbose info even if quiet is specified.  However *most* verbose outputs are guarded by a quiet, meaning if quiet is specified portage will ignore verbose completely; this is what is happening in this case.

I could see the case for two things:

a) Make command line order matter, if it's -qv then verbose turns quiet off, or vice versa.
b) make one always over-ride the other.

I'm all for a) personally.  That way even if a script is overly verbose/quiet I can still affect the outcome without editing the script itself, just by passing certain parameters to it.  b) just means that once I've set one I can't 'unset' it.
Comment 4 solar (RETIRED) gentoo-dev 2006-04-03 06:41:41 UTC
Alec, I dont think getopt ordering should matter in the slightest or be made to.

I'm thinking more along the lines that -qpv should display USE= flags but 
more in the classic style (so they can be parsed easy)

+ [ebuild   R   ] sys-apps/less-394 unicode

And none of those expaned other variables like ELIBC... LANG..
Comment 5 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-04-03 06:44:28 UTC
Personally I'm against that only because I dislike a ton of display logic....How many different levels do we need, although that is more of an implementational detail ( how do you reduce display complexity ) as opposed to why or why we shouldn't have it.
Comment 6 David Watzke 2006-04-03 06:47:33 UTC
Hmm... I like solar's idea :)
Comment 7 Marius Mauch (RETIRED) gentoo-dev 2006-04-03 13:02:51 UTC
How about a numeric verbosity level where -v increases it and -q decreases it? SO -qv would neutralize each other (unless one of them is repeated)? Not sure how well that would work with the current CLI parser though.
Comment 8 David-John Miller 2006-08-05 05:20:31 UTC
Created attachment 93494 [details, diff]
Patch against emerge-2.1.1_pre4-r2

Patch to fix this!
Comment 9 solar (RETIRED) gentoo-dev 2006-08-05 05:24:00 UTC
thanks this patch seems to work perfectly. InSVN revision 4159
Comment 10 Zac Medico gentoo-dev 2006-08-06 04:14:59 UTC
This has been released in 2.1.1_pre4-r4.