Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 125210 - adding x264 USE flag to vlc
Summary: adding x264 USE flag to vlc
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Diego Elio Pettenò (RETIRED)
Depends on:
Reported: 2006-03-06 03:05 UTC by Thomas Krüger
Modified: 2006-03-06 03:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Patch: adds x264 USE flag (vlc_x264.patch,1.12 KB, patch)
2006-03-06 03:06 UTC, Thomas Krüger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Krüger 2006-03-06 03:05:38 UTC
Since x264-svn is more or less working a x264 USE flag could be added to vlc.
Comment 1 Thomas Krüger 2006-03-06 03:06:38 UTC
Created attachment 81501 [details, diff]
Patch: adds x264 USE flag
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-03-06 03:31:32 UTC
Did you actually test it? It fails to compile here because of API mismatch.
Also, x264 does not build the required .so file, just a .a one, and that makes us unable to build it as a plugin, thing that is needed to avoid breaking the whole VLC if x264 is broken.
Comment 3 Thomas Krüger 2006-03-06 03:36:26 UTC
I compiled both several times on two computers: no problem at all.
Decodes and encodes h.264 perfectly.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-03-06 03:44:53 UTC
Err okay I mixed the versions, should wake up better before thinking why I did something, sorry :P

The failure here was not for API mismatch with recent VLC, but rather with PIC mismatch, and that relates with the missing .so ..