Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 121668 - repoman should check for IUSE validity in extra files
Summary: repoman should check for IUSE validity in extra files
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 115839
  Show dependency tree
 
Reported: 2006-02-05 08:12 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-17 01:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portage-2.1_pre4-repoman-extrafiles.patch (portage-2.1_pre4-repoman-extrafiles.patch,638 bytes, patch)
2006-02-05 08:22 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-05 08:12:20 UTC
As discussed on gentoo-dev currently repoman consider INVALID the useflags set in IUSE for use-expanded variables like linguas_*, video_cards_* and so on, requiring them to be documented either in use.local.desc or use.desc. Unfortunately this way we risk to clutter those two files with lot of useflags because things like LINGUAS has a lot of different values.

An alternative solution is to let repoman check into some file called something like linguas.desc for those variables.
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-05 08:22:19 UTC
Created attachment 78944 [details, diff]
portage-2.1_pre4-repoman-extrafiles.patch

Don't say I just bitch about that... here is the patch that does just what I was talking about.
Comment 2 Kito (RETIRED) gentoo-dev 2006-02-05 08:33:11 UTC
This patch worksforme... my only concern would be the potential for an absurd amount of .desc files in profiles/, would a desc profile subdir make sense?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-05 08:42:51 UTC
I thought the same atually, probably a desc subdirectory would help.
Comment 4 Zac Medico gentoo-dev 2006-02-05 09:47:25 UTC
If we're creating a new directory, perhaps it should be somewhere outside of profiles/, such as metadata/desc.  Note that Brian has proposed to move some other files into metadata/.

http://thread.gmane.org/gmane.linux.gentoo.portage.devel/906
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-02-05 09:57:04 UTC
TBH I don't care where the stuff is going, I just want to be able to make use of that without people going to run toward me.
Comment 6 Kito (RETIRED) gentoo-dev 2006-02-05 10:56:08 UTC
(In reply to comment #4)
> If we're creating a new directory, perhaps it should be somewhere outside of
> profiles/, such as metadata/desc.  Note that Brian has proposed to move some
> other files into metadata/.

Ahhh, much better. So skimming over that thread I didn't see any major obstacles to doing this.

So the list for now would be:

> arch.list
> categories
> use.desc
> use.local.desc
> package.mask
> updates
> thirdpartymirrors

plus any use-expand desc files.
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-02 15:11:38 UTC
Ping?
Comment 8 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-04-02 19:22:22 UTC
your patch was commited as is, if it needs to be desc/<files> instead please state so and I will modify it.
Comment 9 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-04-02 19:32:24 UTC
(In reply to comment #8)
> your patch was commited as is, if it needs to be desc/<files> instead please
> state so and I will modify it.
> 

OK I lied, better judgement leaves files in desc/, so the commit was modified for that kind of structure.

USE_EXPAND description files in $PORTDIR/profiles/desc/
Comment 10 Zac Medico gentoo-dev 2006-04-17 01:00:08 UTC
This is in svn r3057 and released in 2.1_pre8.