Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 118394 - app-portage/gentoolkit (revdep-rebuild) fix for "fgrep -l -f - */*/CONTENTS" overflow
Summary: app-portage/gentoolkit (revdep-rebuild) fix for "fgrep -l -f - */*/CONTENTS" ...
Status: RESOLVED DUPLICATE of bug 38751
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-09 05:12 UTC by Alexey Maximov
Modified: 2006-05-10 07:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
revdep-rebuild_overflow.patch (revdep-rebuild_overflow.patch,844 bytes, patch)
2006-01-09 05:14 UTC, Alexey Maximov
Details | Diff
gentoolkit-0.2.2_pre2-r1.ebuild (gentoolkit-0.2.2_pre2-r1.ebuild,1.62 KB, text/plain)
2006-01-09 23:30 UTC, Alexey Maximov
Details
revdep-rebuild-overflow.patch (revdep-rebuild-overflow.patch,897 bytes, patch)
2006-01-09 23:30 UTC, Alexey Maximov
Details | Diff
revdep-rebuild fgrep overflow fix (ver2) (revdep-rebuild-overflow.patch,884 bytes, patch)
2006-03-20 06:03 UTC, Jan Gutter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Maximov 2006-01-09 05:12:14 UTC
see attachment
Comment 1 Alexey Maximov 2006-01-09 05:14:28 UTC
Created attachment 76612 [details, diff]
revdep-rebuild_overflow.patch

please check and add to the main tree

after updating DBUS I unable to revdep and recompile all my system w/o this patch
Comment 2 Alexey Maximov 2006-01-09 20:42:31 UTC
still bad code... wait for new one
Comment 3 Alexey Maximov 2006-01-09 23:20:22 UTC
I created new patch
Comment 4 Alexey Maximov 2006-01-09 23:20:53 UTC
I created new patch
Comment 5 Alexey Maximov 2006-01-09 23:30:06 UTC
Created attachment 76687 [details]
gentoolkit-0.2.2_pre2-r1.ebuild

fixed ebuild
Comment 6 Alexey Maximov 2006-01-09 23:30:44 UTC
Created attachment 76689 [details, diff]
revdep-rebuild-overflow.patch

more correct patch to fix bug
Comment 7 Jan Gutter 2006-03-20 06:03:31 UTC
Created attachment 82654 [details, diff]
revdep-rebuild fgrep overflow fix (ver2)

I didn't have luck with the above patch, but a small re-ordering fixed it on my system. This patch applies to stable and unstable gentoolkit. Is this the correct fix?
Comment 8 Jan Gutter 2006-03-20 06:07:29 UTC
Also, this bug is the same as bug 38751:

http://bugs.gentoo.org/show_bug.cgi?id=38751

This one has been a long standing irritation for me, so it would be nice if somebody closed it ;-)
Comment 9 hulmeman 2006-04-04 02:43:26 UTC
Latest patch works for me, but why is this problem never resolved correctly? This is the fifth or sixth patch for the same problem. 
Yet more reason for the fall of gentoo and the rise of ubuntu!
Comment 10 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-04-04 14:15:39 UTC
(In reply to comment #9)
> Latest patch works for me, but why is this problem never resolved correctly?
> This is the fifth or sixth patch for the same problem. 
> Yet more reason for the fall of gentoo and the rise of ubuntu!
> 

Give me millions of dollars in backing so that I can pay people to do the work; otherwise please try to be patient with the developers.  We are busy people just as you are.
Comment 11 Jan Gutter 2006-04-04 14:44:45 UTC
Comment #9 is a bit out-of-line. Ubuntu certainly has its place, but I really prefer Gentoo for the all-out flexibility. And I've certainly received great support from the Gentoo devs in the past: a large amount of my "bugs" were fixed in less than a day. revdep-rebuild is a relatively non-trivial piece of software: it needs to interface with portage internals that you and I normally don't worry about.

Plus, the above patch is far from perfect: a large number of broken binaries (as opposed to a large number of installed packages) will still trigger an overflow. Maybe replace $(cat <xxxx>) with a $(head -n 100 <xxx>) and tell the user to re-run revdep-rebuild for the rest?

Then again, there might be a more elegant way to do it, and the only thing stopping me from seeing it is trying to implement it in one line ;-)

The coolest way to fix it would actually be to have an arbitrary large command-line buffer ;-)
Comment 12 Harald van Dijk (RETIRED) gentoo-dev 2006-05-04 03:23:37 UTC
(In reply to comment #8)
> Also, this bug is the same as bug 38751:

Right, and marking as such.

(In reply to comment #11)
> Plus, the above patch is far from perfect: a large number of broken binaries
> (as opposed to a large number of installed packages) will still trigger an
> overflow. Maybe replace $(cat <xxxx>) with a $(head -n 100 <xxx>) and tell the
> user to re-run revdep-rebuild for the rest?

I have a patch (many months old, so may not apply to current revdep-rebuild cleanly) in bug #38751 which shouldn't have these problems, but as I noted in the bug, I've never been bitten by this problem myself, so I can't be completely sure.

*** This bug has been marked as a duplicate of 38751 ***
Comment 13 fab6 2006-05-10 07:41:18 UTC
The last patch don't fix the problem for me :(