Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 117919 - net-libs/libwww --as-needed patch
Summary: net-libs/libwww --as-needed patch
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Text-Markup Team (OBSOLETE)
Depends on:
Reported: 2006-01-05 11:59 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-06-04 07:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

libwww-5.4.0-asneeded.patch (libwww-5.4.0-asneeded.patch,378 bytes, patch)
2006-01-05 11:59 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
libwww-5.4.0-asneeded.patch (libwww-5.4.0-asneeded.patch,2.37 KB, patch)
2006-01-06 04:39 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
libwww-5.4.0-noexport.patch (libwww-5.4.0-noexport.patch,402 bytes, patch)
2006-01-06 04:40 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Ebuild patch (libwww-ebuild.patch,1.44 KB, patch)
2006-01-06 04:42 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
automake fails on ppc-macos (automake-5384.out,417 bytes, text/plain)
2006-01-06 05:19 UTC, Fabian Groffen
libwww-5.4.0-automake-osx.patch (libwww-5.4.0-automake-osx.patch,448 bytes, patch)
2006-01-06 05:26 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Ebuild patch 2 (ebuild.patch,1.44 KB, patch)
2006-01-06 05:37 UTC, Fabian Groffen
Details | Diff
libwww-5.4.0-automake-osx.patch (libwww-5.4.0-automake-osx.patch,436 bytes, patch)
2006-01-06 05:44 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
automake (still) fails on ppc-macos (automake.out,4.20 KB, text/plain)
2006-05-14 00:40 UTC, Nick Dimiduk (RETIRED)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-05 11:59:06 UTC
The attached patch allows to build libwww with --as-needed ldflag.

I also suggest to change the ebuild to get rid of all the part between "export WANT_AUTOMAKE" to "autoconf" with an "eautoreconf" call (after inheriting autotools eclass) to simplify it (and dropping ppc-macos special case).

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-05 11:59:26 UTC
Created attachment 76257 [details, diff]
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 04:39:28 UTC
Created attachment 76324 [details, diff]

Updated patch to fix a parallel make issue.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 04:40:51 UTC
Created attachment 76325 [details, diff]

This patch is needed to drop Externls rule that breaks as part of the config/ directory is not shipped with the release tarball.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 04:42:46 UTC
Created attachment 76326 [details, diff]
Ebuild patch

This finally is the patched ebuild I'm using. I also dropped the ppc-macos conditional as I'm trying to get rid of it in the whole tree.
Comment 5 Fabian Groffen gentoo-dev 2006-01-06 05:19:40 UTC
Created attachment 76328 [details]
automake fails on ppc-macos

ppc-macos doesn't like the eautoreconf, see attach.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 05:26:23 UTC
Created attachment 76329 [details, diff]

This should allow to build it on osx, time to see if it still works on Linux, tho.
Comment 7 Fabian Groffen gentoo-dev 2006-01-06 05:37:29 UTC
Created attachment 76330 [details, diff]
Ebuild patch 2

Ok, I added the patch, as in the attached ebuild patch 2.

It doesn't compile:

make[3]: Nothing to be done for `all-am'.
Making all in Library
Making all in src
make  all-recursive
Making all in .
Makefile:1161: *** Recursive variable `CPPFLAGS' references itself (eventually).  Stop.
make[4]: *** [all-recursive] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

!!! ERROR: net-libs/libwww-5.4.0-r4 failed.
!!! Function src_compile, Line 71, Exitcode 2
!!! Compilation failed
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 05:44:09 UTC
Created attachment 76331 [details, diff]

Just drop $(CPPFLAGS), it's not set anywhere anyway.
Comment 9 Fabian Groffen gentoo-dev 2006-01-06 06:10:58 UTC
ok, compiles.  The only notable difference I made is that I named the patch libwww-5.4.0-automake-macos.patch instead of libwww-5.4.0-automake-osx.patch
Comment 10 Alexandre Buisse (RETIRED) gentoo-dev 2006-01-06 06:31:50 UTC
Now in CVS. Thanks.
Comment 11 Nick Dimiduk (RETIRED) gentoo-dev 2006-05-14 00:40:59 UTC
Created attachment 86732 [details]
automake (still) fails on ppc-macos

Can anyone else confirm that this patch works on ppc-macos?  r5 fails for me at automake during eautoreconf.  Attached is my automake output.
Comment 12 Fabian Groffen gentoo-dev 2006-05-14 02:31:03 UTC
flameeyes, it seems your changes broke ppc-macos autoreconf.  I removed the ppc-macos keyword from -r5.
Comment 13 Emanuele Giaquinta (RETIRED) gentoo-dev 2006-05-14 02:49:11 UTC
It is probably an issue with automake-1.6.3; if it is we could drop this since on prefix it will be fine.
Comment 14 Fabian Groffen gentoo-dev 2006-05-14 02:55:45 UTC
agreed, -r4 works fine.
Comment 15 Fabian Groffen gentoo-dev 2006-06-04 07:37:19 UTC
I think since we (ppc-macos) dealt with this, we can close this bug.  If a problem please reopen.  :)