nxserver-freenx doesn't protect its configuration files so when the package is upgraded all config files are blown away (users, passwords, ssh keys).
/usr/NX/etc and /usr/NX/home should be added to CONFIG_PROTECT.
You're quite right. Thanks for spotting this. This is fixed in the freenx-0.5 package in Portage.