Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 115565 - TEXTREL in media-plugins/xmms-mpg123-1.2.10-r1
Summary: TEXTREL in media-plugins/xmms-mpg123-1.2.10-r1
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Hardened (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
Keywords: PMASKED
: 105716 (view as bug list)
Depends on: xmms-must-die
  Show dependency tree
Reported: 2005-12-14 11:05 UTC by Lares Moreau
Modified: 2006-10-23 14:54 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---

xmms-mpg123-1.2.10-PIC-fix.patch (xmms-mpg123-1.2.10-PIC-fix.patch,12.39 KB, patch)
2005-12-14 11:57 UTC, solar (RETIRED)
Details | Diff
solar patch ¿fixed? (xmms-mpg123-1.2.10-PIC-fix.patch,12.39 KB, patch)
2006-03-13 15:07 UTC, SpOeK
Details | Diff
solar patch ¿fixed? (xmms-mpg123-1.2.10-PIC-fix.patch,12.66 KB, patch)
2006-03-13 15:12 UTC, SpOeK
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lares Moreau 2005-12-14 11:05:42 UTC
After some instructions form solar:
media-plugins/xmms-mpg123-1.2.10-r1 (/usr/lib/xmms/Input/
Comment 1 solar (RETIRED) gentoo-dev 2005-12-14 11:57:12 UTC
Created attachment 74751 [details, diff]

This should fix the problem. (Orig patch from PaX Team?)
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-03-07 00:10:13 UTC
*** Bug 105716 has been marked as a duplicate of this bug. ***
Comment 3 SpOeK 2006-03-13 15:07:41 UTC
Created attachment 82044 [details, diff]
solar patch ¿fixed?
Comment 4 SpOeK 2006-03-13 15:07:41 UTC
Created attachment 82044 [details, diff]
solar patch ¿fixed?

I've tried solar's patch but it makes xmms seg fault when connecting to a mp3 stream (

I've reviewed the patch and fixed some lines (well, I think that my changes are fixes, so please, try to be magnanimous :D) . Now it works perfectly for me.

The changes are related to dct36_3dnow.s and dct64_3dnow.s. The rest of the patch is solar's original.
Comment 5 SpOeK 2006-03-13 15:12:29 UTC
Created attachment 82049 [details, diff]
solar patch ¿fixed?
Comment 6 SpOeK 2006-03-13 15:12:29 UTC
Created attachment 82049 [details, diff]
solar patch ¿fixed?

Oops, my previous attachment was solar's patch. Now it's the correct file.
Comment 7 solar (RETIRED) gentoo-dev 2006-03-13 20:17:55 UTC
(In reply to comment #4)
I stated in comment #1 of this bug that the patch does not stem from me.

Adding the PaX Team to CC: list

Comment 8 SpOeK 2006-03-14 01:26:29 UTC
Well, I knew that the patch was not stem from you. "solar's patch" is shorter than "xmms-mpg123-1.2.10-PIC-fix.patch" and as name is not completely wrong/inexact (you uploaded it). I'm sorry!
Comment 9 PaX Team 2006-03-14 03:32:12 UTC
thanks for the fix, i checked it out quickly (interdiff) and it looks fine to me, makes me wonder just what i was thinking back then ;P. solar, can this go into portage then?
Comment 10 solar (RETIRED) gentoo-dev 2006-03-14 04:53:44 UTC
Sound herd. OK to merge this in ~arch?
This fixes a long standing policy about shared objects and pic handling.
Comment 11 SpOeK 2006-03-16 13:55:13 UTC
A question (this is not the best place to ask, I know it), the ebuild xmms-mpg123-1.2.10-r1.ebuild has the following lines:

	if use x86 && ! has_pic && { use mmx || use 3dnow; }; then
		myconf="${myconf} --enable-simd"
		myconf="${myconf} --disable-simd"

If the shared libraries must be always pic and the assembler files now are pic-aware, is the has_pic check necessary?
Comment 12 SpanKY gentoo-dev 2006-03-16 14:03:15 UTC
the ebuild code can drop the has_pic logic now
Comment 13 Jakub Moc (RETIRED) gentoo-dev 2006-10-23 01:07:02 UTC
xmms and all plugins are now package.masked and will be removed from the tree in one month.

@Flameeyes: you forgot to p.mask this one; WONTFIX once done. ;)
Comment 14 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-10-23 01:32:35 UTC
Ready to mask (wait till I commit).