Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 115243 - media-libs/libsdl bundles some X libraries
Summary: media-libs/libsdl bundles some X libraries
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
Depends on:
Reported: 2005-12-11 15:37 UTC by Donnie Berkholz (RETIRED)
Modified: 2010-01-06 05:28 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

libsdl-1.2.10-no-bundled-X.patch (libsdl-1.2.10-no-bundled-X.patch,4.82 KB, patch)
2006-05-25 22:25 UTC, SpanKY
Details | Diff
libsdl-1.2.11-no-bundled-X.patch (libsdl-1.2.11-no-bundled-X.patch,6.36 KB, patch)
2006-07-04 18:06 UTC, Stefan Schweizer (RETIRED)
Details | Diff
libsdl-1.2.11-no-bundled-X.patch (libsdl-1.2.11-no-bundled-X.patch,6.08 KB, patch)
2006-07-05 03:14 UTC, Stefan Schweizer (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Donnie Berkholz (RETIRED) gentoo-dev 2005-12-11 15:37:17 UTC
See src/video/XFree86. The README says:

"The reason these libraries are built outside of the standard XFree86
tree is so that they can be linked as shared object code directly into
SDL without causing any symbol collisions with code in the application.

You can't link static library code into shared libraries on non-x86
Linux platforms.  Since these libraries haven't become standard yet,
we'll just include them directly.

These sources are synchronized with XFree86 4.2.1."

In modular X, pretty much all libraries are built shared so there's no longer
any reason to do this.
Comment 1 SpanKY gentoo-dev 2006-05-25 22:24:49 UTC
decoupling the code isnt trivial so i've poked upstream about some hints on how to go about doing this ...
Comment 2 SpanKY gentoo-dev 2006-05-25 22:25:25 UTC
Created attachment 87529 [details, diff]

i imagine this patch is wrong, but here's a weak attempt
Comment 3 Stefan Schweizer (RETIRED) gentoo-dev 2006-07-04 18:06:57 UTC
Created attachment 90924 [details, diff]

Why should it be wrong and weak? Works fine for me with some minor modifications, adding #define SDL_NAME(X) X in two files :)

Anthing holding this change back?
Comment 4 Stefan Schweizer (RETIRED) gentoo-dev 2006-07-05 03:14:55 UTC
Created attachment 90947 [details, diff]

ok, new patch. Changes:
- add -l(library) to LDFLAGS to make it actually work
- remove xme diffs, xme is not used in the default gentoo build and not provided by modular xorg
Comment 5 Robert Marmorstein 2007-03-09 12:18:17 UTC
I was getting a compile error no libsdl-1.2.11 (something about asm/page.h not being found).  But this patch fixed that problem for me.  Good work!  How soon can we get this into the tree?
Comment 6 SpanKY gentoo-dev 2007-03-14 00:06:32 UTC
upstream has moved to doing this ... i dont think there's any value in trying to backport to versions in portage
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2007-03-21 18:01:16 UTC