Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 114577 - [New Ebuild] media-plugins/gimp-greycstoration-0.2.0
Summary: [New Ebuild] media-plugins/gimp-greycstoration-0.2.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Denis Dupeyron (RETIRED)
URL: http://haypocalc.com/wiki/Gimp_Plugin...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2005-12-05 15:43 UTC by TGL
Modified: 2008-05-30 11:14 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gimp-greycstoration-0.2.0.ebuild (gimp-greycstoration-0.2.0.ebuild,677 bytes, text/plain)
2005-12-05 15:44 UTC, TGL
Details
greycstoration 1.1.1 ebuild (first try) (greycstoration-1.1.1.ebuild,749 bytes, text/plain)
2006-03-04 00:49 UTC, Dario Ernst
Details
media-gfx/greycstoration-2.5.2.1 (greycstoration-2.5.2.1.ebuild,1.89 KB, text/plain)
2007-03-31 16:32 UTC, Damien Thébault
Details
Makefile-2.5.2.1 (Makefile-2.5.2.1,2.14 KB, text/plain)
2007-03-31 16:33 UTC, Damien Thébault
Details

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2005-12-05 15:43:38 UTC
GIMP GREYCstoration is an amazing plugin for improving quality of noisy pictures
(scans from magazines, bad JPEGs, etc.), based on some recent research about
image processing algorithms.

See the website here:
http://haypocalc.com/wiki/Gimp_Plugin_GREYCstoration
and examples here:
http://www.greyc.ensicaen.fr/~dtschump/greycstoration/demo.html

I will attach an ebuild for the new 0.2.0 version. It is pretty simple as you
will see.

Thanks, 
TGL.

Reproducible: Always
Steps to Reproduce:
Comment 1 TGL 2005-12-05 15:44:23 UTC
Created attachment 74120 [details]
gimp-greycstoration-0.2.0.ebuild
Comment 2 TGL 2005-12-05 15:49:41 UTC
allanonjl, i CC you since you may be interested as the gimp maintainer.
Comment 3 frederic bonnaud 2006-01-02 03:27:29 UTC
if "work" on amd64 so you could add "~amd64" to the keywords list.
Comment 4 Zeksers 2006-02-17 08:47:18 UTC
Installed fine but didn't work for me. :(
Comment 5 TGL 2006-02-17 09:12:36 UTC
What do you mean by "does not work"? 
 - it doesn't install "/usr/lib/gimp/2.0/plug-ins/greycstoration"?
 - it doesn't show up in the Filter->Misc menu?
 - the plugin dialog doesn't pop when you select it in the menu?
 - the dialog showup but the plugin doesn't do what it is supposed to?
 - something else?

Also, what is your arch, and gimp version?

Thanks.
Comment 6 Zeksers 2006-02-17 10:59:55 UTC
Sorry, it works now. I just used wrong parametrs to the algorithm.
I think i need to read more before i post.
Comment 7 Dario Ernst 2006-03-04 00:49:30 UTC
Created attachment 81270 [details]
greycstoration 1.1.1 ebuild (first try)

its nice to have a gimp greycstoration plugin ebuild, but what about the "original" greycstoration? a bit before you posted this ebuild i wrote a q'n'd ebuild for greycstoration, but missed to post it.

so - here it is :P
Comment 8 TGL 2006-03-04 01:25:27 UTC
(In reply to comment #7)
> its nice to have a gimp greycstoration plugin ebuild, but what about the
> "original" greycstoration? a bit before you posted this ebuild i wrote a q'n'd
> ebuild for greycstoration, but missed to post it.
> 
> so - here it is :P
> 

I think you should open a new bug for this one. It would be a different package, maybe with a different maintainer, so there is no reason to have both in the same report.

Also, some comments about your ebuild:
 - description is too long i think:
http://dev.gentoo.org/~ciaranm/docs/mw-faq/toolong.txt
 - src_unpack() is redundant:
http://dev.gentoo.org/~ciaranm/docs/mw-faq/redundant.txt
 - hardcoded versions ("CImg-1-11") in SRC_URI are bad:
http://dev.gentoo.org/~ciaranm/docs/mw-faq/hardcoded.txt
(you can use versionator.eclass to turn "1.1.1" into "1-11")
 - same for ${S}, it should be something like "S=${WORKDIR}/CImg-${MY_PV}/examples", which would also avoid the "cd examples/" in src_*()
 - need a DEPEND on "app-arch/unzip" for unpacking
Comment 9 ifreecarve 2007-03-21 02:10:13 UTC
any guesses as to when this will become part of the portage tree?  (i'm curious, not impatient).
Comment 10 Damien Thébault 2007-03-31 16:32:26 UTC
Created attachment 115058 [details]
media-gfx/greycstoration-2.5.2.1

This ebuild uses the 2.5.2.1 version of GREYCstoration (see http://www.greyc.ensicaen.fr/~dtschump/greycstoration/ ), which comes with the gimp plugin.
It's using a custom Makefile to allow USEs (X png jpeg tiff imagemagick fftw gimp).
It's working well for me with:
x11-libs/libX11-1.0.3
x11-libs/libXrandr-1.1.1
x11-libs/libXext-1.0.1
media-libs/libpng-1.2.15
media-libs/jpeg-6b-r7
media-libs/tiff-3.8.2-r2
media-gfx/imagemagick-6.3.0.5
sci-libs/fftw-3.0.1-r2
media-gfx/gimp-2.2.12
Comment 11 Damien Thébault 2007-03-31 16:33:08 UTC
Created attachment 115059 [details]
Makefile-2.5.2.1

Custom makefile to use with attachment #115058 [details]
Comment 12 Denis Dupeyron (RETIRED) gentoo-dev 2008-02-25 10:16:49 UTC
I have just committed media-plugins/gimp-greycstoration to the tree. I believe it's best to have two different packages. I will work on the command-line tool, but you'll have to be patient as it's a big mess to clean up.

(In reply to comment #10)
> This ebuild uses the 2.5.2.1 version of GREYCstoration (see
> http://www.greyc.ensicaen.fr/~dtschump/greycstoration/ ), which comes with the
> gimp plugin.
> It's using a custom Makefile to allow USEs (X png jpeg tiff imagemagick fftw
> gimp).

Your work is very interesting, and your ebuild isn't badly written at all. However, I think it will be a lot easier and cleaner to not use any Makefile. Something similar to what I did in the gimp plugin, and passing options to the compilation command as arguments. I have a semi-working version of this already in my local overlay.

I'm leaving this open until I commit the command-line version to the tree

Denis.
Comment 13 Denis Dupeyron (RETIRED) gentoo-dev 2008-02-25 23:22:29 UTC
(In reply to comment #12)
> I'm leaving this open until I commit the command-line version to the tree

All done, thanks to everybody.

Denis.
Comment 14 Jan Schubert 2008-03-22 18:19:12 UTC
So why is this ebuild called -1.2.7 when the current version about 2.8!? Is this for cimg?

You are sure you reflect a current version?
Comment 15 Denis Dupeyron (RETIRED) gentoo-dev 2008-03-30 18:03:31 UTC
(In reply to comment #14)
> So why is this ebuild called -1.2.7 when the current version about 2.8!? Is
> this for cimg?
> 
> You are sure you reflect a current version?

Yes this was recent. Development of CImg and GREYCstoration occur in parallel. Actually the latter is coding example for the former. At first sight I thought that CImg was updated more frequently. This could still be the case, but GREYCstoration was just updated with major new features, so I switched. Let's hope it doesn't change in the future because it's not going to be easy to revert this.

Anyway, the new version of both the standalone application and the gimp plugin are now in the tree. And I patched the plugin to support multicore/multiprocessor out of the box. Yay !

Denis.
Comment 16 Marek Miller 2008-05-29 22:45:56 UTC
Please add app-arch/unzip to RDEPEND.
Comment 17 Denis Dupeyron (RETIRED) gentoo-dev 2008-05-30 11:14:32 UTC
(In reply to comment #16)
> Please add app-arch/unzip to RDEPEND.

Fixed, thanks.

Denis.