Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 114313 - speech-tools has a conditional gcc-3.4 patch
Summary: speech-tools has a conditional gcc-3.4 patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Gentoo Accessibility Team
URL:
Whiteboard:
Keywords:
: 114434 (view as bug list)
Depends on: 116030
Blocks:
  Show dependency tree
 
Reported: 2005-12-02 20:26 UTC by Mark Loeser (RETIRED)
Modified: 2006-09-08 21:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes C++ stuff so that festival will compile with gcc 4 (festival-gcc4.0.diff,33.01 KB, patch)
2005-12-19 04:02 UTC, Meethune Bhowmick
Details | Diff
Fixes C++ stuff so that speech-tools will compile with gcc 4 (speech-tools-gcc4.0.diff,5.14 KB, patch)
2005-12-19 04:03 UTC, Meethune Bhowmick
Details | Diff
Tarball with updated speech-tools and festival ebuild and patches (speech-tools_festival-gcc4.tar.gz,32.49 KB, application/octet-stream)
2005-12-19 04:04 UTC, Meethune Bhowmick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Loeser (RETIRED) gentoo-dev 2005-12-02 20:26:23 UTC
I am CC'ing sound as well because you both are listed as maintainers.

speech-tools has an evil conditional patch in it, so now every person on x86
upgrading is going to have broken headers when trying to compile festival
because speech-tools was not compiled using gcc-3.4.  The condition in the
ebuild shouldn't exist at all, and we are probably going to have to have to bump
stable on x86 to a new version so people who don't know what the issue is will
have it fixed.

Please remove the condition and let us know which version we should mark stable.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2005-12-04 04:51:59 UTC
*** Bug 114434 has been marked as a duplicate of this bug. ***
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2005-12-07 19:59:01 UTC
Okay, it looks like upstream for this is dead.  I'm unsure why the patches fail
and don't have the time to look into it really.  So can someone from
accessibility either fix the patches or get a replacement for this package?  Or
perhaps one of the other distros has a fix for this already.  Porting this for
gcc-4.0 is probably going to be a complete nightmare as well.
Comment 3 Meethune Bhowmick 2005-12-19 04:02:04 UTC
Created attachment 75080 [details, diff]
Fixes C++ stuff so that festival will compile with gcc 4

This will allow for the package to compile and run, but it throws all kinds of deprecation warnings and whatnot when it compiles. So it could use some cleaning.
Comment 4 Meethune Bhowmick 2005-12-19 04:03:05 UTC
Created attachment 75081 [details, diff]
Fixes C++ stuff so that speech-tools will compile with gcc 4
Comment 5 Meethune Bhowmick 2005-12-19 04:04:37 UTC
Created attachment 75082 [details]
Tarball with updated speech-tools and festival ebuild and patches
Comment 6 Meethune Bhowmick 2005-12-19 04:05:12 UTC
(In reply to comment #2)
> Okay, it looks like upstream for this is dead.  I'm unsure why the patches fail
> and don't have the time to look into it really.  So can someone from
> accessibility either fix the patches or get a replacement for this package?  Or
> perhaps one of the other distros has a fix for this already.  Porting this for
> gcc-4.0 is probably going to be a complete nightmare as well.

I pulled these patches from fedora cvs. These will allow you to compile festival and speech-tools with gcc 4.0.2. It throws up a bunch of warnings so it could use some more scrutiny, but I can echo "All your base are belong to us" | festival --tts and it works :)
Comment 7 Meethune Bhowmick 2005-12-19 04:07:52 UTC
Should my gcc 4 fixes be filed as a new bug?
Comment 8 Mark Loeser (RETIRED) gentoo-dev 2006-01-21 22:21:18 UTC
Alright, keeping x86 on this isn't necessary until we have a fix.  Can someone from accessibility let us know if we are keeping this package or if we are going to p.mask it?  It doesn't look like its had a release in quite some time now.
Comment 9 William Hubbs gentoo-dev 2006-09-08 21:05:22 UTC
This is resolved by 116030.  Closing.  Thanks.