Bug 113844 – net-libs/libssh2 - new ebuild

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Joe 2005-11-28 14:06:23 UTC]

This is a new ebuild for libssh2 (www.libssh2.org). This is NOT the same as
libssh (0xbadc0de.be), which is currently in Portage. Both are libraries which
implement the SSH2 protocol. However, they offer different APIs and are named
slightly different (libssh vs libssh2).

It should be noted that one of the libssh2 functions waits indefinitely if a SSH
server fails to return its banner. I've included a patch which works around this
issue. This patch has also been sent to the libssh2 maintainers.

Joe

[Comment 1 Joe 2005-11-28 14:07:26 UTC]

Created attachment 73764 [details]
ebuild

[Comment 2 Joe 2005-11-28 14:07:59 UTC]

Created attachment 73765 [details, diff]
patch referenced in ebuild

[Comment 3 Petteri Räty (RETIRED) 2005-12-04 14:27:45 UTC]

A couple of comments to improve your ebuild writing skills for the future:
LICENSE="BSD License"
This needs to match a file in ${PORTDIT}/licenses

DEPEND="
	dev-libs/openssl
"

This can be on one line.

src_unpack: you can inherit base after which you can just do 
PATCHES="${FILESDIR}/${P}-banner-wait.patch"

src_compile, src_installl: these are useless as they do the same as the
functions you can inherit from base, but see the followind advice:

src_compile:
use flag support for for example debug and looking at the INSTALL file
       * --with-zlib=[DIR]

                If present, libssh2 will attempt to use the zlib
(http://www.zlib.org)
                for payload compression, however zlib is not required.

Because it seems that zlib support can't be disabled, it should be in DEPEND too.

src_install:
install the README file using dodoc

In the future tell the version of libssh2 you made the ebuild for so people can
easily test.

Thanks for the work so far.

[Comment 4 Joe 2006-01-04 12:06:07 UTC]

Created attachment 76173 [details]
updated ebuild (libssh2 0.12)

Thanks for the tips. I've cleaned up the ebuild a bit.

[Comment 5 Marcelo Goes (RETIRED) 2006-05-01 14:22:04 UTC]

Hi there,

0.13 is out, did upstream give you any reason for not including your patch?

Marcelo

[Comment 6 Joe 2006-05-03 07:14:59 UTC]

I haven't received a reason for the patch being excluded. I'm attempting to reopen communication with the developers to find an acceptable way to address this issue. If this patch is holding back getting the ebuild in portage, please just exclude it. The patch addresses an issue which occurs when many concurrent unauthenticated connections are opened to a SSH server. Most uses of the library shouldn't encounter this...

[Comment 7 Marcelo Goes (RETIRED) 2006-05-03 08:07:42 UTC]

Actually it was more along the lines of "I wonder why"... :-)

[Comment 8 Cédric Krier 2006-06-30 07:16:19 UTC]

This is now in the sunrise overlay. You can find it at:
http://gentoo-sunrise.org/svn/reviewed/net-libs/libssh2

[Comment 9 Jakub Moc (RETIRED) 2006-11-02 10:02:39 UTC]

*** Bug 153837 has been marked as a duplicate of this bug. ***

[Comment 10 Markus Ullmann (RETIRED) 2006-11-27 15:57:46 UTC]

Imported to CVS, thanks for the ebuild :)