At http://www.rahul.net/dholmes/ctorrent/ you can find a patch file with various bug/code fixes and improvements. It would be good if they were added to the net-p2p/ctorrent ebuild, maybe with a use-flag to toggle the patch on/off. Reproducible: Always Steps to Reproduce: 1. emerge ctorrent 2. watch the emerge 3. don't see any trace of the patch Actual Results: The emerge finishes without the above mentioned patch being added. Expected Results: The patch should have been added. In the case of an use-flag: The patch should have been added after enabling the use-flag "enhanced", for example. For completeness i will copy&paste the features of the patch here: Bug/code fixes Peer count would increase on each tracker update if there were no seeders. RequestQueue::CopyShuffle() changed to use a pointer argument. Fixed some incorrectness in PendingQueue::Delete() and PendingQueue:: DeleteSlice() which could cause a memory leak. Fixed random-chance inversion bug in PeerList::UnChokeCheck() affecting choice for optimistic unchoking. Improvements Move StopDLTimer() call from RequestPiece() to RequestCheck(), which could occasionally affect peer download rate measurement. Most clients do not like a slice size of 128K even though it is the max allowed by the BT specification. Changed max slice size to 64K. Note that the maximum piece length is 2MB (2097152); if you need to download a torrent with a larger piece size you can change the value of cfg_req_queue_length in btconfig.h from 64 to 128. Contact tracker immediately upon becoming (or starting as) a seeder. Changed SendModule() to send only one slice at a time. This will help with fairly distributing upload bandwidth among the unchoked peers. Changed default peer ID prefix to '-CD0101-', indicating CTorrent-dnh1.1 release.
Created attachment 72782 [details, diff] Release dnh1
Created attachment 72783 [details, diff] Release dnh1.1
*** Bug 131903 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of 131903 ***
