Just tried to update libdv to 0.104-r1 to test the new pic patch. It compiles here well with gcc-3.4.4 fails however with gcc-4.0.2-r1. Here is the error output make all-recursive make[1]: Entering directory `/var/tmp/portage/libdv-0.104-r1/work/libdv-0.104' Making all in libdv make[2]: Entering directory `/var/tmp/portage/libdv-0.104-r1/work/libdv-0.104/libdv' if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -march=athlon-xp -m3dnow -O2 -pipe -fomit-frame-pointer -Wall -MT gasmoff.o -MD -MP -MF ".deps/gasmoff.Tpo" -c -o gasmoff.o gasmoff.c; \ then mv -f ".deps/gasmoff.Tpo" ".deps/gasmoff.Po"; else rm -f ".deps/gasmoff.Tpo"; exit 1; fi /bin/sh ../libtool --silent --mode=link --tag=CC i686-pc-linux-gnu-gcc -march=athlon-xp -m3dnow -O2 -pipe -fomit-frame-pointer -Wall -Wl,-O1 -Wl,--sort-common -s -o gasmoff gasmoff.o -lm ./gasmoff > asmoff.h make all-am make[3]: Entering directory `/var/tmp/portage/libdv-0.104-r1/work/libdv-0.104/libdv' if /bin/sh ../libtool --silent --mode=compile --tag=CC i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -march=athlon-xp -m3dnow -O2 -pipe -fomit-frame-pointer -Wall -MT dv.lo -MD -MP -MF ".deps/dv.Tpo" -c -o dv.lo dv.c; \ then mv -f ".deps/dv.Tpo" ".deps/dv.Plo"; else rm -f ".deps/dv.Tpo"; exit 1; fi In file included from dv.c:51: quant.h:30: error: array type has incomplete element type dv.c: In function 'dv_decode_macroblock': dv.c:224: error: type of formal parameter 5 is incomplete dv.c: In function 'dv_decode_video_segment': dv.c:256: error: type of formal parameter 5 is incomplete make[3]: *** [dv.lo] Error 1 make[3]: Leaving directory `/var/tmp/portage/libdv-0.104-r1/work/libdv-0.104/libdv' make[2]: *** [all] Error 2 make[2]: Leaving directory `/var/tmp/portage/libdv-0.104-r1/work/libdv-0.104/libdv' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/libdv-0.104-r1/work/libdv-0.104' make: *** [all] Error 2 !!! ERROR: media-libs/libdv-0.104-r1 failed. !!! Function src_compile, Line 42, Exitcode 2 !!! compile problem emerge info Portage 2.0.53_rc7 (default-linux/x86/2005.0, gcc-4.0.2, glibc-2.3.5.20050722-r0, 2.6.14-gentoo i686) ================================================================= System uname: 2.6.14-gentoo i686 AMD Athlon(tm) XP 1800+ Gentoo Base System version 1.12.0_pre9 ccache version 2.4 [enabled] dev-lang/python: 2.4.2 sys-apps/sandbox: 1.2.13 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 sys-devel/binutils: 2.16.1 sys-devel/libtool: 1.5.20 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-march=athlon-xp -m3dnow -O2 -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/share/X11/xkb /usr/share/config /var/bind /var/qmail/control /var/service" CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d" CXXFLAGS="-march=athlon-xp -m3dnow -O2 -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig ccache distlocks fixpackages sandbox sfperms strict" GENTOO_MIRRORS="http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--sort-common -s" LINGUAS="de en" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/overlays/bmg-main /usr/local/portage" SYNC="rsync://rsync.de.gentoo.org/gentoo-portage/" USE="x86 3dnow 3dnowex X aalib acl acpi alsa arts artswrappersuid async avi berkdb bitmap-fonts bmp browserplugin bzip2 cairo cdrom chipcard chroot crypt cups curl dbus directfb dri dvd dvdread eds emboss encode epiphany esd fb fbcon ffmpeg firefox flac flash font-server foomaticdb fortran freetype gb gd gdbm gif gimp gimpprint glibc-omitfp glitz gnome gnomedb gnutls gpm gstreamer gtk gtk2 gtkhtml guile hal hbci howl imagemagick imlib insecure-drivers java javascript jpeg kde kdeenablefinal lcms ldap libcaca libg++ libgda libwww lzw-tiff mad mikmod mmx mmx2 motif mozilla moznocompose moznoirc moznomail mozpango mozpython mozsvg mp3 mpeg nautilus ncurses nfsv4 nls nptl nptlonly nsplugin nvidia odbc ogg oggvorbis opengl oss pam pdf pdflib perl pic pie png postscript pwdb python qt quicktime readline real rtc ruby samba scanner sdl slang spell sse ssl svg svga symlink tcltk tcpd tga tiff truetype truetype-fonts type1-fonts udev unicode ups usb userlocales uudeview vorbis win32codecs wmf xine xml xml2 xmms xosd xprint xscreensaver xv xvid zlib video_cards_nvidia linguas_de linguas_en userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CTARGET, LC_ALL As said before same setup switching to gcc-3.4.4 would work. However, if you want to send your patch upstream, you may want to consider the gcc4 failure
(In reply to comment #0) > As said before same setup switching to gcc-3.4.4 would work. However, if you > want to send your patch upstream, you may want to consider the gcc4 failure We don't have any patch. If you have one, then please attach it; otherwise, gcc-4 is still package.masked and unsupported.
thanks for reporting Walter this is the kinda of feedback we were looking for. Btw how well is it preforming with gcc-3.4.x?
can you add an #include <stdint.h> to quant.h and see if the compiles?
Created attachment 71956 [details, diff] fix for gcc4 This should fix the compil. Please could anyone try it and check if libdv is still working fine?
(In reply to comment #4) > Created an attachment (id=71956) [edit] > fix for gcc4 > > This should fix the compil. Please could anyone try it and check if libdv is > still working fine? It compiles (some warnigs though). However I have problems with example files 4x3.dv or 16x9.dv from the sourceforge-site running in gdb format 4:3 Audio is 48.0 kHz, 16 bits quantization, 2 channels, emphasis off Xv: NV17 Video Overlay: ports 244 - 244 Xv: grabbed port 244 Using Xv for display Program received signal SIGSEGV, Segmentation fault. 0xb798eb2c in ?? () from /usr/lib/libdv.so.4 (I'm not sure if my setup causes this, because I had also segfaults after compiling with gcc-3.4.4)
(In reply to comment #4) > Created an attachment (id=71956) [edit] > fix for gcc4 > > This should fix the compil. Please could anyone try it and check if libdv is > still working fine? make it uint8_t * for both pointers.
Created attachment 74450 [details] ebuild+patch for fix gcc4 problem ebuild+patch for fix gcc4 problem
(In reply to comment #7) > ebuild+patch for fix gcc4 problem compiles fine, playdv starts but same result as in comment #5 If I'm the only one who has this problem, close the bug if you want to, its not my most important program, sorry if I caused you trouble
(In reply to comment #8) > (In reply to comment #7) > > ebuild+patch for fix gcc4 problem > > compiles fine, playdv starts but same result as in comment #5 If I'm the only > one who has this problem, close the bug if you want to, its not my most > important program, sorry if I caused you trouble i had a few bugs in the asm chunks, i sent out a new version today for review, i guess it'll be put it into portage soon.
chutzpah added a patch to fix the compilation issue a week or so ago. Thanks for the report.
*** Bug 140647 has been marked as a duplicate of this bug. ***
*** Bug 145825 has been marked as a duplicate of this bug. ***
It seems this bug also affects media-libs/libdv-0.102, the stable version. Did the patch reach the unstable version ?
(In reply to comment #13) > It seems this bug also affects media-libs/libdv-0.102, the stable version. Did > the patch reach the unstable version ? see bug #121871 for the discussion there.
