Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 109474 - kalzium in 3.5.0 has support for ocaml+libfacile
Summary: kalzium in 3.5.0 has support for ocaml+libfacile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 114132 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-16 08:00 UTC by Dan Armak (RETIRED)
Modified: 2006-09-01 06:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Armak (RETIRED) gentoo-dev 2005-10-16 08:00:49 UTC
Kalzium can use libfacile (an ocaml lib) for chem. eq. solving. There's no 
libfacile ebuild in portage atm. Also, the kalzium/configure.in.in check for 
libfacile isn't controlled by a configure parameter.
Comment 1 Dan 2005-10-17 17:27:38 UTC
This has been fixed by upstream for 3.5.0_beta2, which is released tommorow (the configure.in 
check at least.. facile ebuild comes maybe sometime.. 
Comment 2 Dan 2005-10-17 18:09:18 UTC
Sorry for bugspam.. It wasn't fixed, Misunderstanding with the developer of kde I was talking to.. 
 
patch incoming shortly.. 
Comment 3 Pino Toscano 2005-10-28 09:32:50 UTC
SVN commit 475256 by pino: 
 
Add a configure flag to easily disable the Kalzium ocaml solver. 
 
@gentoo-kde team: could you please the bug? 
 
CCMAIL: 109474@bugs.gentoo.org 
 
 
Comment 4 Pino Toscano 2005-10-28 09:32:50 UTC
SVN commit 475256 by pino: 
 
Add a configure flag to easily disable the Kalzium ocaml solver. 
 
@gentoo-kde team: could you please the bug? 
 
CCMAIL: 109474@bugs.gentoo.org 
 
 
 M  +1 -1      configure.in.bot   
 M  +29 -20    configure.in.in   
 
 
--- branches/KDE/3.5/kdeedu/kalzium/configure.in.bot #475255:475256 
@@ -1,4 +1,4 @@ 
-if test "x$eqchem_enabled" = "xno"; then 
+if test x$eqchem_enabled = xno && test x$with_ocamlsolver != xno ; then 
     cat << EOF 
  
 The Kalzium Chemical Equation Solver has been disabled. Possible 
--- branches/KDE/3.5/kdeedu/kalzium/configure.in.in #475255:475256 
@@ -29,29 +29,38 @@ 
     AC_SUBST([FACILE]) 
 ]) 
  
-OCAML_PROG 
-if test -n "$OCAML"; then 
-   ocaml_installed=yes 
-   FACILE_PROG 
-fi 
+AC_ARG_ENABLE( ocamlsolver, 
+  [  --disable-ocamlsolver       Disable support for the OCaml solver 
@<:@default=check@:>@]], 
+  [  with_ocamlsolver=$enableval ], 
+  [  with_ocamlsolver=check] ) 
  
-AH_TEMPLATE(HAVE_FACILE, facile solver available?) 
+if test "x$with_ocamlsolver" != xno; then 
+  OCAML_PROG 
+  if test -n "$OCAML"; then 
+    ocaml_installed=yes 
+    FACILE_PROG 
+  fi 
  
-EQCHEM_SUB= 
-OCAMLLIB= 
-EQCHEM_LDADD= 
-if test "$eqchem_enabled" = "yes"; then 
-   EQCHEM_SUB=solver 
-   OCAMLLIB=`ocamlc -where` 
-   FACILELIB=`ocamlc -where`/facile 
-   EQCHEM_LDADD="-lasmrun -lstr -lnums -lm -ldl solver.o modwrap.o" 
+  AH_TEMPLATE(HAVE_FACILE, facile solver available?) 
  
-   AC_DEFINE(HAVE_FACILE, 1) 
-fi 
+  EQCHEM_SUB= 
+  OCAMLLIB= 
+  EQCHEM_LDADD= 
+  if test "$eqchem_enabled" = "yes"; then 
+    EQCHEM_SUB=solver 
+    OCAMLLIB=`ocamlc -where` 
+    FACILELIB=`ocamlc -where`/facile 
+    EQCHEM_LDADD="-lasmrun -lstr -lnums -lm -ldl solver.o modwrap.o" 
  
-AC_SUBST(EQCHEM_SUB) 
-AC_SUBST(OCAMLLIB) 
-AC_SUBST(FACILELIB) 
-AC_SUBST(EQCHEM_LDADD) 
+    AC_DEFINE(HAVE_FACILE, 1) 
+  fi 
  
+  AC_SUBST(EQCHEM_SUB) 
+  AC_SUBST(OCAMLLIB) 
+  AC_SUBST(FACILELIB) 
+  AC_SUBST(EQCHEM_LDADD) 
  
+  if test "$eqchem_enabled" = "yes"; then 
+    with_ocamlsolver=yes 
+  fi 
+fi 
Comment 5 Gregorio Guidi (RETIRED) gentoo-dev 2005-12-01 05:52:56 UTC
*** Bug 114132 has been marked as a duplicate of this bug. ***
Comment 6 Gregorio Guidi (RETIRED) gentoo-dev 2005-12-01 06:06:45 UTC
Passing --disable-ocamlsolver to configure for now. 
Comment 7 Thomas Bettler 2006-08-31 03:51:54 UTC
Will --disable-ocamlsolver be replaced by a useflag sometimes in future?
Comment 8 Patrick Kursawe (RETIRED) gentoo-dev 2006-09-01 06:10:43 UTC
(In reply to comment #6)
> Will --disable-ocamlsolver be replaced by a useflag sometimes in future?

I guess it won't happen before libfacile is in portage.