109013 – Request: games-roguelike/nethack - enable #define SCORE_ON_BOTL

Bug 109013 - Request: games-roguelike/nethack - enable #define SCORE_ON_BOTL

Summary: Request: games-roguelike/nethack - enable #define SCORE_ON_BOTL

Status:	RESOLVED WONTFIX

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	Mira Ressel

URL:
Whiteboard:
Keywords:

Depends on:	113224
Blocks:
	Show dependency tree

Reported:	2005-10-12 08:17 UTC by Christian Kuenstner
Modified:	2015-06-09 11:48 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Christian Kuenstner 2005-10-12 08:17:29 UTC

What do you think about defining SCORE_ON_BOTL in include/config.h to enable the
option "showscore" in nethack?

This is the diff:

--- include/config.h.orig       2005-10-12 16:54:51.000000000 +0200
+++ include/config.h    2005-10-12 16:55:16.000000000 +0200
@@ -341 +341 @@
-/* #define SCORE_ON_BOTL */    /* added by Gary Erickson (erickson@ucivax) */
+#define SCORE_ON_BOTL  /* added by Gary Erickson (erickson@ucivax) */

Reproducible: Always
Steps to Reproduce:

Comment 1 Kiyoshi Aman 2005-11-05 09:30:31 UTC

This has the possibility of affecting the bitfields so as to overflow
boundaries, therefore creating savegame incompatibility. This [usually] is not a
problem if one doesn't patch their Nethack.

Comment 2 Mira Ressel 2015-06-09 11:48:29 UTC

As Kiyoshi noted, this change is not entirely unproblematic; therefore I think those users who want it should enable it by applying a local patch. I've added an epatch_user call to the ebuild; so doing so is very simple.