Bug 108382 – catalyst appends kernel args multiple times

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description georg.lippold 2005-10-07 06:52:31 UTC]

catalyst 1.1.10.10 appends kernel args multiple times in the append line of
isolinux (this may also be true for other bootloaders, didn't check). Since
/proc/cmdline is currently limited to 256 chars, this is especially regretful.
A simple fix for /usr/lib/catalyst/livecd/runscript/x86-archscript.sh is appended.

Reproducible: Always
Steps to Reproduce:
1. in livecd-stage2.spec, define livecd/bootargs: vga=791
2. build a livecd
3. edit isolinux/isolinux.cfg on the iso. vga=791 will be listed two times

[Comment 1 georg.lippold 2005-10-07 06:53:59 UTC]

Created attachment 70078 [details, diff]
fix for kernel args

[Comment 2 georg.lippold 2005-10-07 06:57:54 UTC]

Created attachment 70080 [details, diff]
fix for kernel args

first diff was in the wrong direction

[Comment 3 Chris Gianelloni (RETIRED) 2005-10-07 07:22:32 UTC]

I don't see what you're trying to fix.

Catalyst only appends the arguments *once* per kernel.  This has been verified
by me over several *hundred* catalyst runs, along with every other Release
Engineering member, as they've done their countless release builds using this
tool, too.

[Comment 4 georg.lippold 2005-10-07 08:30:28 UTC]

Created attachment 70092 [details]
isolinux.cfg created by catalyst

[Comment 5 georg.lippold 2005-10-07 08:31:29 UTC]

Created attachment 70093 [details]
livecd-stage2.spec used to generate isolinux.cfg

[Comment 6 georg.lippold 2005-10-07 08:31:50 UTC]

Please check this out...

[Comment 7 Chris Gianelloni (RETIRED) 2005-10-07 11:14:06 UTC]

Why are you adding options that are already a default in your livecd-stage2?

You're also using --gensplash-res, which is causing even more of the issues, as
it completely overrides the -nofb option's capabilities.  At any rate, it is a
configuration issue, and not an issue with catalyst.  I'm really not sure that
we should be spending time trying to sanitize the user's input.  It's my
personal feeling that the user knows best.

I'll think about including the sanitizing code.

[Comment 8 georg.lippold 2005-10-07 11:51:09 UTC]

Created attachment 70109 [details, diff]
fix for kernel args

added = at the end of options, otherwise grep would get errors with looptype=
and loop=

[Comment 9 Chris Gianelloni (RETIRED) 2005-12-20 09:27:48 UTC]

rocket: what do you think about this for catalyst 2.0?

I tend to think that if the user is going to put things that are busted in their bootargs, that we shouldn't be trying to sanitize it...

[Comment 10 Chris Gianelloni (RETIRED) 2006-01-13 07:25:03 UTC]

We're not in the business of telling the user what to do... they're free to break their boot all on their own... :P