Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 103452 - Make gtk+-2.x smoothscroll patch optional
Summary: Make gtk+-2.x smoothscroll patch optional
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 103453 103456 115770 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-08-23 07:09 UTC by Tero Grundström
Modified: 2006-11-05 12:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tero Grundström 2005-08-23 07:09:46 UTC
Could you please consider making the gtk+ smoothscroll patch optional?

My main point is that it can make some software like gtk2 email clients almost
unusable on slower machines.

There are other points too:
- this is an unofficial feature
- portage has the power to do this
- Mozilla Firefox and WinXp have this feature too ;)

My suggestion is that 'smoothscroll' can be enabled/disabled via a USE flag.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2005-08-23 07:26:26 UTC
*** Bug 103453 has been marked as a duplicate of this bug. ***
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2005-08-23 07:48:50 UTC
*** Bug 103456 has been marked as a duplicate of this bug. ***
Comment 3 Tero Grundström 2005-08-23 08:01:00 UTC
I'm sorry about the dublicate bugs. Bugzilla seemed to be down when I tried to
submit it, so I pushed the stop button and in the meantime checked if I wanted
to change anything in my report... I didn't realize that all of them were sent
anyway.
Comment 4 Tero Grundström 2005-08-23 08:28:43 UTC
Ok.. so this report didn't go too smoothly. Anyways... I feel that this is
important and as I said in bug #103456, this affects all gtk2 text editors as well.

Also, what I mean by "Firefox and WinXP having this feature" is that they
provide an option to disable smooth scrolling. And for a good reason too, IMO.
Comment 5 konsti 2005-11-16 05:08:36 UTC
*lol* I was just about to file the same Bug :-)
Comment 6 Marcelo Goes (RETIRED) gentoo-dev 2005-11-22 11:11:48 UTC
Any word on this?
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2005-12-16 07:15:21 UTC
*** Bug 115770 has been marked as a duplicate of this bug. ***
Comment 8 John N. Laliberte (RETIRED) gentoo-dev 2006-02-01 06:35:26 UTC
we need to decide if we are removing, keeping, or making this patch optional since its a gentoo-only patch. ( unsupported upstream )

reference here:
http://bugzilla.gnome.org/show_bug.cgi?id=103811
Comment 9 Giacomo Perale 2006-02-13 06:52:14 UTC
I see that smoothscroll has been removed in gtk+ 2.8.12. Could you reconsider this decision? I'm sure that many users love it.
Comment 10 Daniel Gryniewicz (RETIRED) gentoo-dev 2006-02-13 19:48:26 UTC
No, we decided we didn't want to support local feature patches such as this.  If you really care about it, you should try and get it accepted upstream.
Comment 11 foser (RETIRED) gentoo-dev 2006-02-19 07:52:08 UTC
I think that is a regression from what we had. The fact that the upstream maintainers have ignored the patch doesn't mean it isn't an important usability feature gtk really should have and Gentoo has been promoting for a long time now.

The main issue in this bug seems to be with the existance of the patch, not with the actual feature it adds, I don't see why this request got honored in the first place.
Comment 12 John N. Laliberte (RETIRED) gentoo-dev 2006-03-14 18:12:29 UTC
we need a proper patch submitted on the upstream bug.  Anyone interested should provide a proper patch to upstream.
Comment 13 foser (RETIRED) gentoo-dev 2006-03-15 04:48:33 UTC
The patch is sufficient, it is a regression that it got removed.

The esd patch is not upstream either, still we have it. Don't measure with 2 sticks.
Comment 14 Erlend Davidson 2006-03-26 04:40:50 UTC
(In reply to comment #10)
> No, we decided we didn't want to support local feature patches such as this. 
> If you really care about it, you should try and get it accepted upstream.
> 

Surely local patches which can be turned on with USE flags is a part of the power of gentoo?  Otherwise you might as well be running a binary-only distro.
Comment 15 Erlend Davidson 2006-04-15 08:43:10 UTC
(In reply to comment #13)
> The patch is sufficient, it is a regression that it got removed.
> 
> The esd patch is not upstream either, still we have it. Don't measure with 2
> sticks.
> 

Could the smoothscroll patch be re-added as an optional (probably opt-in) USE flag please?  Not having smoothscroll after once having it makes things feel awful.  I'm currently running it by applying the patch using solar's http://dev.gentoo.org/~solar/portage_misc/bashrc.autopatch, but that won't work forever.
Comment 16 Giacomo Perale 2006-09-26 05:59:55 UTC
smoothscroll patch for gtk+ 2.8 doesn't apply anymore to gtk+ 2.10. Is there any hope that the patch will be updated?
Comment 17 Doug Goldstein (RETIRED) gentoo-dev 2006-09-26 17:22:59 UTC
foser: You are a walking contradiction.... Copying and pasting from the upstream bug...

Comment #16 from Owen Taylor    (gtk+ developer, points: 25) 
The Gentoo people really need a big LART. Not only was this patch
not considered ready to go into GTK+, it changes the GTK+ public
API...


Well that sounds like a darn good enough reason for me for us not to include it.


Comment #17 from Ernst Persson    (points: 8) 
<foser> ernstp: i'm not happy you added my  patch without my consent.. i made it
buildable, i still consider it halfbroken
<foser> it is open.. but i'm not pushing it for inclusion as long as i'm not
content with it, thats the difference tberman 


It changes the GTK+ public APIs... toss it.
Comment 18 John N. Laliberte (RETIRED) gentoo-dev 2006-11-05 12:04:51 UTC
we will not re-apply or update this patch.