| Summary: | games-simulation/simutrans-124.1: does not compile with net-libs/miniupnpc-2.2.8 error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’ | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | tea <tea+gentoo> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mgorny |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://forum.simutrans.com/index.php/topic,23136.0.html | ||
| See Also: | https://github.com/gentoo/gentoo/pull/37357 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build log | ||
forgot to add the lik to the miniupnpc changelog: <miniupnp.free.fr/files/changelog.php?file=miniupnpc-2.2.8.tar.gz>
> UPNP_GetValidIGD(): distinguish between not connected and connected to a
> "private" network (with a reserved IP address).
> Increments API_VERSION to 18
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84c4b307d7073adfeb1de635e0d6e09819befe92 commit 84c4b307d7073adfeb1de635e0d6e09819befe92 Author: tastytea <gentoo@tastytea.de> AuthorDate: 2024-06-29 11:43:18 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-07-26 07:40:31 +0000 games-simulation/simutrans: fix net-libs/miniupnpc dependency miniupnpc changed API in 2.2.8, simutrans doesn't build with it - patch 124.0 - restrict miniupnpc version in 123.0.1-r2 Bug: https://bugs.gentoo.org/935134 Signed-off-by: tastytea <gentoo@tastytea.de> Closes: https://github.com/gentoo/gentoo/pull/37357 Signed-off-by: Joonas Niilola <juippis@gentoo.org> games-simulation/simutrans/simutrans-123.0.1-r2.ebuild | 2 +- games-simulation/simutrans/simutrans-124.0.ebuild | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab6e0062c94e108d8b9f8840d0cf786453688d5f commit ab6e0062c94e108d8b9f8840d0cf786453688d5f Author: Petr Vaněk <arkamar@gentoo.org> AuthorDate: 2025-02-27 13:17:08 +0000 Commit: Petr Vaněk <arkamar@gentoo.org> CommitDate: 2025-02-27 13:34:07 +0000 games-simulation/simutrans: drop 124.1 Closes: https://bugs.gentoo.org/935134 Signed-off-by: Petr Vaněk <arkamar@gentoo.org> games-simulation/simutrans/Manifest | 3 - .../files/simutrans-124.1-fix-miniupnpc-api.patch | 42 -------- games-simulation/simutrans/simutrans-124.1.ebuild | 114 --------------------- 3 files changed, 159 deletions(-) |
Created attachment 896619 [details] build log miniupnpc changed the number of arguments for UPNP_GetValidIGD() in 2.2.8, which causes the simutrans build to fail. this also is true for simutrans-124.0. it works fine with miniupnpc-2.2.7. i believe this may be problem with more packages.