Summary: | dev-qt/qtwebengine-5.15.9_p20230404: fails to compile with gcc-13 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | he.ousia <he.ousia> |
Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 865117 | ||
Attachments: |
first part of build log
second part of build log |
Description
he.ousia
2023-04-14 22:27:51 UTC
Please attach the full build.log - compressed if necessary. Created attachment 860111 [details]
first part of build log
Created attachment 860112 [details]
second part of build log
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0d451f42732bc1c8685e56d64f13d73d2596d77 commit f0d451f42732bc1c8685e56d64f13d73d2596d77 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-04-15 01:05:53 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-04-15 02:10:44 +0000 dev-qt/qtwebengine: fix build w/ GCC 13 Closes: https://bugs.gentoo.org/904342 Signed-off-by: Sam James <sam@gentoo.org> .../files/qtwebengine-5.15.9_p20230404-gcc-13.patch | 14 ++++++++++++++ dev-qt/qtwebengine/qtwebengine-5.15.9_p20230404.ebuild | 5 ++++- 2 files changed, 18 insertions(+), 1 deletion(-) cstdint must also be included in src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.h Only then the entire package compiles OK. (In reply to he.ousia from comment #5) > cstdint must also be included in > src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/ > dark_mode_image_classifier.h > Only then the entire package compiles OK. That header doesn't use anything from <cstdint> AFAICT but dark_mode_image_classifier.cc does. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f46bba05316d58aa6071adfa714c976aa8405e3 commit 8f46bba05316d58aa6071adfa714c976aa8405e3 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-04-15 09:31:55 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-04-15 09:32:30 +0000 dev-qt/qtwebengine: fix build w/ gcc 13 Closes: https://bugs.gentoo.org/904342 Signed-off-by: Sam James <sam@gentoo.org> .../files/qtwebengine-5.15.9_p20230404-gcc-13.patch | 10 ++++++++++ 1 file changed, 10 insertions(+) (In reply to Sam James from comment #6) > (In reply to he.ousia from comment #5) > > cstdint must also be included in > > src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/ > > dark_mode_image_classifier.h > > Only then the entire package compiles OK. > > That header doesn't use anything from <cstdint> AFAICT but > dark_mode_image_classifier.cc does. dark_mode_image_classifier.cc includes dark_mode_image_classifier.h (In reply to he.ousia from comment #8) > (In reply to Sam James from comment #6) > > (In reply to he.ousia from comment #5) > > > cstdint must also be included in > > > src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/ > > > dark_mode_image_classifier.h > > > Only then the entire package compiles OK. > > > > That header doesn't use anything from <cstdint> AFAICT but > > dark_mode_image_classifier.cc does. > > dark_mode_image_classifier.cc includes dark_mode_image_classifier.h yes, my point is that the thing which uses it is the thing which should include it. so I've put it in .cc instead. With the new patch compiles and works very well (tested within Falkon, with several online benchmarking/stress testing tools). |