Summary: | www-client/firefox: fails to compile with GCC 13 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugzilla.mozilla.org/show_bug.cgi?id=1811714 https://bugzilla.mozilla.org/show_bug.cgi?id=1807652 https://bugs.gentoo.org/show_bug.cgi?id=892465 https://bugs.gentoo.org/show_bug.cgi?id=904268 https://bugs.gentoo.org/show_bug.cgi?id=902025 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 865117 | ||
Attachments: | build.log.xz |
Description
Sam James
2023-01-22 02:37:03 UTC
There are further issues with -fpermissive after fixing the trivial include problem: ``` 0:20.11 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h: At global scope: 0:20.11 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h:217:38: error: declaration of 'mozilla::profiler::ThreadRegistration::OnThreadRef::RWOnThreadWithLock mozilla::profiler::ThreadRegistration::OnThreadRef::LockedRWOnThread()' changes meaning of 'LockedRWOnThread' [-fpermissive] 0:20.11 217 | [[nodiscard]] RWOnThreadWithLock LockedRWOnThread() { 0:20.11 | ^~~~~~~~~~~~~~~~ 0:20.11 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h:213:7: note: used here to mean 'using mozilla::profiler::ThreadRegistration::LockedRWOnThread = class mozilla::profiler::ThreadRegistrationLockedRWOnThread' 0:20.11 213 | LockedRWOnThread& mLockedRWOnThread; 0:20.12 | ^~~~~~~~~~~~~~~~ 0:20.12 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h:63:9: note: declared here 0:20.12 63 | using LockedRWOnThread = ThreadRegistrationLockedRWOnThread; 0:20.12 | ^~~~~~~~~~~~~~~~ 0:20.12 In file included from /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadState.h:15: 0:20.12 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistry.h:180:43: error: declaration of 'mozilla::profiler::ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock mozilla::profiler::ThreadRegistry::OffThreadRef::LockedRWFromAnyThread()' changes meaning of 'LockedRWFromAnyThread' [-fpermissive] 0:20.12 180 | [[nodiscard]] RWFromAnyThreadWithLock LockedRWFromAnyThread() { 0:20.12 | ^~~~~~~~~~~~~~~~~~~~~ 0:20.12 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistry.h:176:7: note: used here to mean 'using mozilla::profiler::ThreadRegistry::LockedRWFromAnyThread = class mozilla::profiler::ThreadRegistrationLockedRWFromAnyThread' 0:20.12 176 | LockedRWFromAnyThread& mLockedRWFromAnyThread; 0:20.13 | ^~~~~~~~~~~~~~~~~~~~~ 0:20.13 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistry.h:33:9: note: declared here 0:20.13 33 | using LockedRWFromAnyThread = ThreadRegistrationLockedRWFromAnyThread; 0:20.13 | ^~~~~~~~~~~~~~~~~~~~~ 0:20.13 gmake[4]: *** [/var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/config/rules.mk:669: Unified_cpp_ipc_extension_other0.o] Error 1 ``` mliska reported them already upstream at https://bugzilla.mozilla.org/show_bug.cgi?id=1807652. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d361fad3aa2fb3229d5ec972268ec52da37f5abc commit d361fad3aa2fb3229d5ec972268ec52da37f5abc Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-01-24 09:51:51 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-01-24 10:01:30 +0000 www-client/firefox: update patchset for 109.0 - include gcc-13 fixes, - include updated webrtc patch on ppc64. Closes: https://bugs.gentoo.org/891643 Bug: https://bugs.gentoo.org/891389 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 2 +- www-client/firefox/firefox-109.0.ebuild | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) |