Summary: | app-xemacs/ebuild-mode-1.61 stable request | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ulrich Müller <ulm> |
Component: | Stabilization | Assignee: | XEmacs team <xemacs> |
Status: | RESOLVED WONTFIX | ||
Severity: | enhancement | Keywords: | ALLARCHES, STABLEREQ |
Priority: | Normal | Flags: | nattka:
sanity-check+
|
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: |
app-xemacs/ebuild-mode-1.61
|
Runtime testing required: | Manual |
Description
Ulrich Müller
2023-01-15 11:54:27 UTC
ping (In reply to Ulrich Müller from comment #1) > ping Sorry for not acting on this but not sure I should either. Please advice. Anyway, going through the tests I noticed there is a bug in ebuild-mode due to the XEmacs function format-time-string only taking two args and not supporting the %F format character. This affects two test cases. Saving of an ebuild and creating a new. After adjusting ebuild-mode.el for this the test cases pass. I think you have commented on the incompatibilities between Emacs and XEmacs before so not sure how you want to go about this here. The problem still remains with the current upstream master branch so bumping to latest XEmacs 21.5 will not help here right now. These incompatibilities show up in the most unexpected places. I'm going to fix it and make a new release. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=5f5a1855dbb33450c5d5c588bb76ab5cb0542bd7 commit 5f5a1855dbb33450c5d5c588bb76ab5cb0542bd7 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-02-21 17:05:01 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-02-21 17:05:01 +0000 New compatibility function for format-time-string in XEmacs * ebuild-mode.el (ebuild-mode-time-string): New compatibility function for format-time-string, where XEmacs doesn't support the time zone argument. Bug 890933. (ebuild-mode-update-copyright, ebuild-mode-insert-skeleton) (ebuild-mode-insert-tag-line): Call it. Bug: https://bugs.gentoo.org/890933#c2 Signed-off-by: Ulrich Müller <ulm@gentoo.org> ChangeLog | 8 ++++++++ ebuild-mode.el | 23 ++++++++++++++++++++--- 2 files changed, 28 insertions(+), 3 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=a9e3d40bfacb6714381792e9256afda9d22b2673 commit a9e3d40bfacb6714381792e9256afda9d22b2673 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-02-21 17:05:01 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-02-21 18:58:12 +0000 New compatibility function for format-time-string in XEmacs * ebuild-mode.el (ebuild-mode-time-string): New compatibility function for format-time-string, where XEmacs doesn't support the time zone argument. Bug 890933. (ebuild-mode-update-copyright, ebuild-mode-insert-skeleton) (ebuild-mode-insert-tag-line): Call it. (ebuild-mode-update-copyright): Save match data, because setenv clobbers it. Bug: https://bugs.gentoo.org/890933#c2 Signed-off-by: Ulrich Müller <ulm@gentoo.org> ChangeLog | 10 ++++++++++ ebuild-mode.el | 23 ++++++++++++++++++++--- 2 files changed, 30 insertions(+), 3 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=2bfe87a7afe45b48268e97d4dd7c9e0edd49e426 commit 2bfe87a7afe45b48268e97d4dd7c9e0edd49e426 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-02-21 17:05:01 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-02-21 19:09:54 +0000 New compatibility function for format-time-string in XEmacs * ebuild-mode.el (ebuild-mode-time-string): New compatibility function for format-time-string, where XEmacs doesn't support the time zone argument. Bug 890933. (ebuild-mode-update-copyright, ebuild-mode-insert-skeleton) (ebuild-mode-insert-tag-line): Call it. (ebuild-mode-update-copyright): Save match data, because setenv clobbers it. Bug: https://bugs.gentoo.org/890933#c2 Signed-off-by: Ulrich Müller <ulm@gentoo.org> ChangeLog | 10 ++++++++++ ebuild-mode.el | 23 ++++++++++++++++++++--- 2 files changed, 30 insertions(+), 3 deletions(-) (In reply to Mats Lidell from comment #2) Can you test app-xemacs/ebuild-mode-9999 (from emacs overlay)? As far as I can see, it should work with both XEmacs 21.4 and 21.5. (In reply to Ulrich Müller from comment #7) > (In reply to Mats Lidell from comment #2) > > Can you test app-xemacs/ebuild-mode-9999 (from emacs overlay)? As far as I > can see, it should work with both XEmacs 21.4 and 21.5. Yes. It works with both. Thanks for fixing this. |