Bug 871621 – media-gfx/inkscape-1.2.1-r2 fails tests

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jonathan Lovelace 2022-09-19 00:56:24 UTC]

=media-gfx/inkscape-1.2.1-r2 fails its test phase for me; the test log (and the build log itself) indicate that this is because the test programs weren't built before ctest tried to run them. Searching the Web, I found https://gitlab.com/inkscape/inbox/-/issues/4424 , which isn't *precisely* the same because cmake_src_test calls ctest directly rather than through "make test", but I suspect the solution found there of either passing "--build-and-test" to ctest or calling "emake tests" before calling ctest should fix the issue.

[Comment 1 Jonathan Lovelace 2022-09-19 00:57:20 UTC]

Created attachment 812593 [details]
LastTest.log

[Comment 2 Jonathan Lovelace 2022-09-19 01:00:07 UTC]

Created attachment 812596 [details]
media-gfx:inkscape-1.2.1-r2:20220918-202428.log.gz

[Comment 3 Jonathan Lovelace 2022-09-19 01:00:52 UTC]

Created attachment 812599 [details]
emerge-info.txt

[Comment 4 Jonathan Lovelace 2022-09-21 01:55:16 UTC]

I tried adding "emake tests" to the ebuild, but there isn't a Makefile there (or anywhere outside of $S/src/3rdparty except $S/share/extensions). Adding a call to "eninja tests" (making sure $PWD at that point is the build directory, $WORKDIR/${P}_build), on the other hand, allows the tests to run successfully.

(I also tried adding --build-and-test to the "myctestargs" array, and eventually got it to work as well (it requires source-dir and build-dir as arguments, and also requires the --build-generator option with its own argument), but that appeared to completely rebuild everything from scratch, so it's a far inferior solution.)

[Comment 5 Larry the Git Cow 2023-09-18 04:30:00 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=be35cf883544c0f0c73b00748601e411b9140b7c

commit be35cf883544c0f0c73b00748601e411b9140b7c
Author:     Sam James <[e-mail]>
AuthorDate: 2023-09-18 04:22:30 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-09-18 04:29:45 +0000

    media-gfx/inkscape: fix building tests, fix gtksourceview automagic
    
    * Fix building tests. Still restricted but fewer fail now.
    * Port to CMAKE_SKIP_TESTS.
    * Wire up gtksourceview.
    
    Closes: https://bugs.gentoo.org/871621
    Signed-off-by: Sam James <[e-mail]>

 media-gfx/inkscape/inkscape-1.3.ebuild  | 17 ++++++++++++++---
 media-gfx/inkscape/inkscape-9999.ebuild | 21 ++++++++++++++++-----
 media-gfx/inkscape/metadata.xml         |  1 +
 profiles/arch/hppa/package.use.mask     |  4 ++++
 4 files changed, 35 insertions(+), 8 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=421ad224a895f8edf0a27c3cf2b70fc72c1f44e9

commit 421ad224a895f8edf0a27c3cf2b70fc72c1f44e9
Author:     Sam James <[e-mail]>
AuthorDate: 2023-09-18 03:50:28 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-09-18 04:23:28 +0000

    media-gfx/inkscape: disable tests
    
    We need to figure out the test failures (see the hint in the bug).
    
    Bug: https://bugs.gentoo.org/871621
    Signed-off-by: Sam James <[e-mail]>

 media-gfx/inkscape/inkscape-1.2.2-r4.ebuild | 8 +++-----
 media-gfx/inkscape/inkscape-1.2.2.ebuild    | 8 +++-----
 media-gfx/inkscape/inkscape-1.3.ebuild      | 8 +++-----
 media-gfx/inkscape/inkscape-9999.ebuild     | 8 +++-----
 4 files changed, 12 insertions(+), 20 deletions(-)