Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 723314

Summary: sci-calculators/tilp2-1.18 configure error when /bin/sh != bash (PATCH)
Product: Gentoo Linux Reporter: Matt Whitlock <gentoo>
Component: Current packagesAssignee: Gentoo Science Related Packages <sci>
Status: RESOLVED FIXED    
Severity: normal CC: jstein, sam
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 526268    
Attachments: fix-configure-bashism.patch

Description Matt Whitlock 2020-05-16 05:35:51 UTC
Created attachment 639494 [details, diff]
fix-configure-bashism.patch

tilp2's configure.ac contains a Bashism (use of == operator with test built-in). Thus, configure emits an error when /bin/sh is not Bash. This doesn't cause the build to fail outright, but it may be causing misdetection of features.

if test "x$build" == "x$host" ; then

checking for the host compiler... ./configure: 20469: test: xx86_64-pc-linux-gnu: unexpected operator

The attached patch removes the Bashism and allows sci-calculators/tilp2-1.18 to configure without error when /bin/sh is Dash.
Comment 1 Larry the Git Cow gentoo-dev 2021-08-20 02:18:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe419f34f7df788b25799373c54d80ecde80c9ae

commit fe419f34f7df788b25799373c54d80ecde80c9ae
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-08-20 02:14:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-08-20 02:14:08 +0000

    sci-calculators/tilp2: fix bashism in configure
    
    Thanks-to: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://bugs.gentoo.org/723314
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-calculators/tilp2/files/tilp2-1.18-nonbash.patch | 12 ++++++++++++
 sci-calculators/tilp2/tilp2-1.18.ebuild              |  4 ++++
 2 files changed, 16 insertions(+)