Summary: | media-sound/beets-1.4.9-r1 USE=webserver should conditionally depend on dev-python/flask-cors | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | arcctgx |
Component: | Current packages | Assignee: | Guillaume Seren <guillaumeseren> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arcctgx, juippis, proxy-maint |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://github.com/gentoo/gentoo/pull/15519 https://github.com/gentoo/gentoo/pull/16046 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 693164 | ||
Bug Blocks: | |||
Attachments: |
emerge --info output
build.log |
Sorry, accidentally submitted before finishing the description. From the build log: >>> Preparing source in /var/tmp/portage/media-sound/beets-1.4.9-r1/work/beets-1.4.9 ... ... * no webserver: * removing web (full build log attached) The web plugin is not built likely because of the following part of profiles/base/package.use.mask: # Andreas Sturmlechner <asturm@gentoo.org> (2019-12-07) # dev-python/flask-cors is PMASKED. media-sound/beets webserver which was introduced by commit ff5418a7b5d. I think dev-python/flask-cors is only necessary if someone wants to enable CORS in the beets web plugin (it's disabled by default). I'm using beets web plugin without flask-cors on a different machine (running Slackware64-14.2), and it works just fine. Perhaps masking the "webserver" USE flag just because there is a problem with flask-cors goes a bit too far? Created attachment 599536 [details]
build.log
Hey, I have been working on this ebuild, I see the use flags was masqued in the profile, can we re enable it ? I'm not invested in this package. Maybe I wasn't clear sorry. (In reply to Andreas Sturmlechner from comment #4) > I'm not invested in this package. Yes I understand but I try to upgrade the ebuild and cleanup the issues, as this one could be solved by unmasking the USEĀ flags in profile, (masked by unless I am wrong). My question is how can this flag be unmasked ? If there's anything I can fix in the ebuild, I can do it. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b599ad6587752063fd42e3b9c7fed33771d494e commit 3b599ad6587752063fd42e3b9c7fed33771d494e Author: Guillaume Seren <guillaumeseren@gmail.com> AuthorDate: 2020-04-25 17:31:10 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-06-01 12:28:16 +0000 media-sound/beets: cleanup ebuild Closes: https://bugs.gentoo.org/718398 Bug: https://bugs.gentoo.org/702914 Bug: https://bugs.gentoo.org/693164 Closes: https://bugs.gentoo.org/584276 Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-sound/beets/beets-1.4.9-r1.ebuild | 179 +++++++++++++++++++------------- 1 file changed, 107 insertions(+), 72 deletions(-) If it's fixed, please make a PR where you handle the profile masks and point it to close this bug with 'Closes:' tag. Hey juippis, I see this message was written before the commit c9ea4ce3a03267955c2823953eebc31961320670 I am preparing a cleanup commit that will close this bug Also I will delete this mask in 'profiles/base/package.use.mask', in my PR. I have remove the PMASK and add a new usee flag for cors, because it is disabled by default as stated in the doc see: https://beets.readthedocs.io/en/stable/plugins/web.html?highlight=web The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=926bac37a3457662195f3169f69745d555826c2c commit 926bac37a3457662195f3169f69745d555826c2c Author: Guillaume Seren <guillaumeseren@gmail.com> AuthorDate: 2020-06-01 21:18:03 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-01-18 12:27:04 +0000 media-sound/beets: Drop PMASK on webserver Closes: https://bugs.gentoo.org/702914 Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> profiles/base/package.use.mask | 4 ---- 1 file changed, 4 deletions(-) |
Created attachment 599534 [details] emerge --info output Today I updated beets to the most recent version 1.4.9-r1. After the update the web server plugin is not available anymore: $ beet web ** error loading plugin web: Traceback (most recent call last): File "/usr/lib64/python3.6/site-packages/beets/plugins.py", line 273, in load_plugins namespace = __import__(modname, None, None) ModuleNotFoundError: No module named 'beetsplug.web' error: unknown command 'web' I have the "webserver" flag set in my package.use file: $ grep beets /etc/portage/package.use/settings media-sound/beets chromaprint webserver But despite the above the web plugin is not built: