Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 702914 - media-sound/beets-1.4.9-r1 USE=webserver should conditionally depend on dev-python/flask-cors
Summary: media-sound/beets-1.4.9-r1 USE=webserver should conditionally depend on dev-p...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Guillaume Seren
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 693164
Blocks:
  Show dependency tree
 
Reported: 2019-12-14 16:27 UTC by arcctgx
Modified: 2020-09-21 11:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info output (emerge_info.txt,5.78 KB, text/plain)
2019-12-14 16:27 UTC, arcctgx
Details
build.log (media-sound:beets-1.4.9-r1:20191214-152719.log,76.20 KB, text/plain)
2019-12-14 16:39 UTC, arcctgx
Details

Note You need to log in before you can comment on or make changes to this bug.
Description arcctgx 2019-12-14 16:27:57 UTC
Created attachment 599534 [details]
emerge --info output

Today I updated beets to the most recent version 1.4.9-r1. After the update the web server plugin is not available anymore:

$ beet web
** error loading plugin web:
Traceback (most recent call last):
  File "/usr/lib64/python3.6/site-packages/beets/plugins.py", line 273, in load_plugins
    namespace = __import__(modname, None, None)
ModuleNotFoundError: No module named 'beetsplug.web'

error: unknown command 'web'

I have the "webserver" flag set in my package.use file:

$ grep beets /etc/portage/package.use/settings
media-sound/beets chromaprint webserver

But despite the above the web plugin is not built:
Comment 1 arcctgx 2019-12-14 16:38:41 UTC
Sorry, accidentally submitted before finishing the description.

From the build log:

>>> Preparing source in /var/tmp/portage/media-sound/beets-1.4.9-r1/work/beets-1.4.9 ...
...
 * no webserver:
 *   removing web

(full build log attached)

The web plugin is not built likely because of the following part of profiles/base/package.use.mask:

# Andreas Sturmlechner <asturm@gentoo.org> (2019-12-07)
# dev-python/flask-cors is PMASKED.
media-sound/beets webserver

which was introduced by commit ff5418a7b5d.

I think dev-python/flask-cors is only necessary if someone wants to enable CORS in the beets web plugin (it's disabled by default). I'm using beets web plugin without flask-cors on a different machine (running Slackware64-14.2), and it works just fine. Perhaps masking the "webserver" USE flag just because there is a problem with flask-cors goes a bit too far?
Comment 2 arcctgx 2019-12-14 16:39:28 UTC
Created attachment 599536 [details]
build.log
Comment 3 Guillaume Seren 2020-04-25 21:28:39 UTC
Hey,
I have been working on this ebuild, I see the use flags was masqued in the profile, can we re enable it ?
Comment 4 Andreas Sturmlechner gentoo-dev 2020-04-25 21:50:20 UTC
I'm not invested in this package.
Comment 5 Guillaume Seren 2020-04-27 17:44:29 UTC
Maybe I wasn't clear sorry.

(In reply to Andreas Sturmlechner from comment #4)
> I'm not invested in this package.

Yes I understand but I try to upgrade the ebuild and cleanup the issues,
as this one could be solved by unmasking the USE flags in profile,
(masked by unless I am wrong).


My question is how can this flag be unmasked ?


If there's anything I can fix in the ebuild, I can do it.
Comment 6 Larry the Git Cow gentoo-dev 2020-06-01 12:28:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b599ad6587752063fd42e3b9c7fed33771d494e

commit 3b599ad6587752063fd42e3b9c7fed33771d494e
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2020-04-25 17:31:10 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-06-01 12:28:16 +0000

    media-sound/beets: cleanup ebuild
    
    Closes: https://bugs.gentoo.org/718398
    Bug: https://bugs.gentoo.org/702914
    Bug: https://bugs.gentoo.org/693164
    Closes: https://bugs.gentoo.org/584276
    
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/beets/beets-1.4.9-r1.ebuild | 179 +++++++++++++++++++-------------
 1 file changed, 107 insertions(+), 72 deletions(-)
Comment 7 Joonas Niilola gentoo-dev 2020-06-01 12:33:35 UTC
If it's fixed, please make a PR where you handle the profile masks and point it to close this bug with 'Closes:' tag.
Comment 8 Guillaume Seren 2020-06-01 19:30:06 UTC
Hey juippis,
I see this message was written before the commit c9ea4ce3a03267955c2823953eebc31961320670

I am preparing a cleanup commit that will close this bug
Comment 9 Guillaume Seren 2020-06-01 21:11:52 UTC
Also I will delete this mask in 'profiles/base/package.use.mask',
in my PR.
Comment 10 Guillaume Seren 2020-06-01 21:24:14 UTC
I have remove the PMASK and add a new usee flag for cors,
because it is disabled by default as stated in the doc see:
https://beets.readthedocs.io/en/stable/plugins/web.html?highlight=web