Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584276 - media-sound/beets-1.3.13 Add bash completion
Summary: media-sound/beets-1.3.13 Add bash completion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2016-05-27 02:08 UTC by Emily Mills
Modified: 2020-06-01 12:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild with bash completion (beets-1.3.13.ebuild,2.78 KB, text/plain)
2016-05-27 02:08 UTC, Emily Mills
Details
Patch illustrating the ebuild changes (beets-1.3.13.ebuild.patch,605 bytes, patch)
2016-06-03 12:53 UTC, Emily Mills
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Mills 2016-05-27 02:08:05 UTC
Created attachment 435508 [details]
Updated ebuild with bash completion

I've attached an updated ebuild that installs a bash completion file for beets. Beets includes a built-in command to generate a bash completion script. This is executed in the ebuild so the upstream bash completion can be used.
Comment 1 Michael 'veremitz' Everitt 2016-06-03 08:17:18 UTC
Would you mind re-factoring your ebuild as a diff/patch, as I think the changes become a bit more transparent from that (just done it manually!)? Thanks.
Comment 2 Emily Mills 2016-06-03 12:53:32 UTC
Created attachment 436302 [details, diff]
Patch illustrating the ebuild changes
Comment 3 Guillaume Seren 2020-04-25 21:09:02 UTC
Hey,
while working on 718398 I discovered this patch,
so I merged into my work to solve this issue.

Any review is welcome.
Comment 4 Larry the Git Cow gentoo-dev 2020-06-01 12:28:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b599ad6587752063fd42e3b9c7fed33771d494e

commit 3b599ad6587752063fd42e3b9c7fed33771d494e
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2020-04-25 17:31:10 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-06-01 12:28:16 +0000

    media-sound/beets: cleanup ebuild
    
    Closes: https://bugs.gentoo.org/718398
    Bug: https://bugs.gentoo.org/702914
    Bug: https://bugs.gentoo.org/693164
    Closes: https://bugs.gentoo.org/584276
    
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/beets/beets-1.4.9-r1.ebuild | 179 +++++++++++++++++++-------------
 1 file changed, 107 insertions(+), 72 deletions(-)