| Summary: | dev-embedded/xa-2.3.9 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | doj |
| Component: | New packages | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jstein |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=656722 https://github.com/gentoo/gentoo/pull/13504 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
dev-embedded/xa-2.3.9 ebuild
dev-embedded/xa-2.3.9 Makefile patch dev-embedded/xa-2.3.9 ebuild dev-embedded/xa metadata file |
||
Created attachment 577208 [details, diff]
dev-embedded/xa-2.3.9 Makefile patch
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) remove # -*- mode: shell-script -*- * KEYWORDS need ~ for new ebuilds. Run ekeyword ~all YOUREBUILD * We usually sort the KEYWORDS as ekeywords does. This makes comparison between packages easier. Simply run ekeywords on the ebuild to let it sort. * A bot can look for additional mistakes, if you upload a PR via github Created attachment 577238 [details]
dev-embedded/xa-2.3.9 ebuild
second version of this ebuild.
Created attachment 577240 [details]
dev-embedded/xa metadata file
thanks for the comments Jonas, I've made the requested changes to the ebuild. Now repoman only complains about a missing ChangeLog file. I don't have the time right now to set up a GIT account and learn the workflow, please take it from here. Pull request [1], feel free to improve, if interested, I'll merge it. [1] https://github.com/gentoo/gentoo/pull/13504 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf37fc7848e3369526f28fa199247173b014e120 commit bf37fc7848e3369526f28fa199247173b014e120 Author: David Heidelberg <david@ixit.cz> AuthorDate: 2019-10-30 20:51:04 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2019-11-18 23:30:41 +0000 dev-embedded/xa: New package Thanks to doj@cubic.org. Bug: https://bugs.gentoo.org/686234 Bug: https://github.com/gentoo/gentoo/pull/13504 Signed-off-by: David Heidelberg <david@ixit.cz> Signed-off-by: James Le Cuirot <chewi@gentoo.org> dev-embedded/xa/Manifest | 1 + dev-embedded/xa/files/xa-2.3.9-Makefile.patch | 18 ++++++++++++++++++ dev-embedded/xa/metadata.xml | 14 ++++++++++++++ dev-embedded/xa/xa-2.3.9.ebuild | 18 ++++++++++++++++++ 4 files changed, 51 insertions(+) |
Created attachment 577206 [details] dev-embedded/xa-2.3.9 ebuild attached is an ebuild and patch file for a new package dev-embedded/xa