Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686234 - dev-embedded/xa-2.3.9
Summary: dev-embedded/xa-2.3.9
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-05-18 16:26 UTC by doj
Modified: 2020-01-10 20:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-embedded/xa-2.3.9 ebuild (xa-2.3.9.ebuild,449 bytes, text/plain)
2019-05-18 16:26 UTC, doj
Details
dev-embedded/xa-2.3.9 Makefile patch (xa-2.3.9-Makefile.patch,443 bytes, patch)
2019-05-18 16:26 UTC, doj
Details | Diff
dev-embedded/xa-2.3.9 ebuild (xa-2.3.9.ebuild,407 bytes, text/plain)
2019-05-18 20:59 UTC, doj
Details
dev-embedded/xa metadata file (metadata.xml,540 bytes, text/xml)
2019-05-18 20:59 UTC, doj
Details

Note You need to log in before you can comment on or make changes to this bug.
Description doj 2019-05-18 16:26:06 UTC
Created attachment 577206 [details]
dev-embedded/xa-2.3.9 ebuild

attached is an ebuild and patch file for a new package dev-embedded/xa
Comment 1 doj 2019-05-18 16:26:34 UTC
Created attachment 577208 [details, diff]
dev-embedded/xa-2.3.9 Makefile patch
Comment 2 Jonas Stein gentoo-dev 2019-05-18 17:49:50 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman

* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
 remove # -*- mode: shell-script -*-

* KEYWORDS need ~ for new ebuilds. Run ekeyword ~all YOUREBUILD

* We usually sort the KEYWORDS as ekeywords does. This makes comparison between packages easier. Simply run ekeywords on the ebuild to let it sort.

* A bot can look for additional mistakes, if you upload a PR via github
Comment 3 doj 2019-05-18 20:59:11 UTC
Created attachment 577238 [details]
dev-embedded/xa-2.3.9 ebuild

second version of this ebuild.
Comment 4 doj 2019-05-18 20:59:33 UTC
Created attachment 577240 [details]
dev-embedded/xa metadata file
Comment 5 doj 2019-05-18 21:00:34 UTC
thanks for the comments Jonas, I've made the requested changes to the ebuild. Now repoman only complains about a missing ChangeLog file.

I don't have the time right now to set up a GIT account and learn the workflow, please take it from here.
Comment 6 David Heidelberg (okias) 2019-10-30 21:08:12 UTC
Pull request [1], feel free to improve, if interested, I'll merge it.

[1] https://github.com/gentoo/gentoo/pull/13504
Comment 7 Larry the Git Cow gentoo-dev 2019-11-18 23:35:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf37fc7848e3369526f28fa199247173b014e120

commit bf37fc7848e3369526f28fa199247173b014e120
Author:     David Heidelberg <david@ixit.cz>
AuthorDate: 2019-10-30 20:51:04 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-11-18 23:30:41 +0000

    dev-embedded/xa: New package
    
    Thanks to doj@cubic.org.
    
    Bug: https://bugs.gentoo.org/686234
    Bug: https://github.com/gentoo/gentoo/pull/13504
    Signed-off-by: David Heidelberg <david@ixit.cz>
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 dev-embedded/xa/Manifest                      |  1 +
 dev-embedded/xa/files/xa-2.3.9-Makefile.patch | 18 ++++++++++++++++++
 dev-embedded/xa/metadata.xml                  | 14 ++++++++++++++
 dev-embedded/xa/xa-2.3.9.ebuild               | 18 ++++++++++++++++++
 4 files changed, 51 insertions(+)