Summary: | media-video/vlc-3.0.4 USE=fdk - codec/fdkaac.c:291:34: error: ‘AACENC_InfoStruct’ {aka ‘struct <anonymous>’} has no member named ‘encoderDelay’; did you mean ‘nDelay’? | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Leonid Kopylov <leonchik1976> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | althorion, andig.mail, andrzej.kardas, atoth, b.buschinski, chewi, chris, josef64, klaus.kusche, mail, randy-andy-, stefantalpalaru, steffen, vivo75, zeekec |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | https://trac.videolan.org/vlc/ticket/21533 | ||
Whiteboard: | fixed in 3.0.6-r1 | ||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 678702 | ||
Bug Blocks: | |||
Attachments: |
build.log
Fixes tis error. |
Description
Leonid Kopylov
2018-11-30 11:05:00 UTC
Created attachment 556770 [details]
build.log
This is a problem after upgrade to media-libs/fdk-aac-2.0.0 which changes the ABI (for one, encoderDelay was changed to nDelay). Same here. Confirmed here too. (In reply to Luke A. Guest from comment #4) > Confirmed here too. https://github.com/mstorsjo/fdk-aac/issues/93 Created attachment 556986 [details, diff]
Fixes tis error.
(In reply to Luke A. Guest from comment #6) > Created attachment 556986 [details, diff] [details, diff] > Fixes tis error. Patch works for me. Thanks! Is the patch not good enough to be added to the tree? Is there something else we're waiting for? (In reply to Chris Smith from comment #8) > Is the patch not good enough to be added to the tree? Is there something > else we're waiting for? It works for me. If you don't want to wait you can copy the patch to /etc/portage/patches/media-video/vlc/0001-Fix-FDKAAC-AACENC_InfoStruct-member-name-change-from.patch where the vlc ebuild will pick it up automatically. A fixed vlc-3.0.4-r1 is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay (In reply to Luke A. Guest from comment #6) > Created attachment 556986 [details, diff] [details, diff] > Fixes tis error. Did you submit this patch upstream for review? It is not in vlc.git master yet. Can we track an upstream bug number? Looking at the diff, I wonder what was the pressing need to change the field name and break stuff all over? This is bad development model and reviewer did not do his/her job. vlc-3.0.6 (didn't test 3.0.5) builds against media-libs/fdk-aac-2.0.0 without any patch being required... (In reply to Lars Wendler (Polynomial-C) from comment #13) > vlc-3.0.6 (didn't test 3.0.5) builds against media-libs/fdk-aac-2.0.0 > without any patch being required... Err, no, I was wrong. Sorry, I checked trhe buidl with USE="-fdk" (I thought I had that added to my package.use file but I didn't). So the bug still isn't fixed by upstream... The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=690c91858babd424e44e9ccf938e74f73fb85e94 commit 690c91858babd424e44e9ccf938e74f73fb85e94 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-01-12 23:48:32 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-01-13 00:12:42 +0000 media-video/vlc: Restrict to <media-libs/fdk-aac-2.0.0 Bug: https://bugs.gentoo.org/672290 Package-Manager: Portage-2.3.55, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-video/vlc/vlc-3.0.6.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://git.videolan.org/?p=vlc.git;a=commit;h=6ea9b13fe82fae2b25b7371c6c36d6296db28ccb "Fix building vlc with libfdk-aac v2 When flushing the encoder, we now need to provide non-null buffer parameters for everything, even if they are unused. The encoderDelay parameter has been replaced by two, nDelay and nDelayCore." The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=315cd1cf34c962f988d7a7806a0e9843da0ff77e commit 315cd1cf34c962f988d7a7806a0e9843da0ff77e Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-02-24 17:22:27 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-02-24 18:01:24 +0000 media-video/vlc: Fix build with libvpx-1.8.0, fdk-aac-2.0.0 Thanks-to: jospezial <jospezial@gmx.de> Bug: https://bugs.gentoo.org/677606 Bug: https://bugs.gentoo.org/672290 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../vlc/files/vlc-3.0.6-fdk-aac-2.0.0.patch | 84 ++++ media-video/vlc/files/vlc-3.0.6-libvpx-1.8.0.patch | 35 ++ media-video/vlc/vlc-3.0.6-r1.ebuild | 501 +++++++++++++++++++++ 3 files changed, 620 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e542b54bceb8e672006a4af535bcd3f91ab19b07 commit e542b54bceb8e672006a4af535bcd3f91ab19b07 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-03-16 21:32:31 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-03-16 22:41:42 +0000 media-video/vlc: Drop 3.0.4 Closes: https://bugs.gentoo.org/672290 Closes: https://bugs.gentoo.org/677606 Closes: https://bugs.gentoo.org/669924 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-video/vlc/Manifest | 1 - media-video/vlc/vlc-3.0.4.ebuild | 490 --------------------------------------- 2 files changed, 491 deletions(-) |