Summary: | dev-libs/libp11: libressl support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Crypto team [DISABLED] <crypto+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alonbl, tsmksubc |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/OpenSC/libp11/issues/135 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 561854 | ||
Attachments: |
config.log
dev-libs:libp11-0.4.2:20161029-043217.log emerge-history.txt environment libp11-0.4.4-libressl-2.8.3.patch libp11-0.4.9-compat-LibreSSL-2.8.3.patch |
Description
Toralf Förster
2016-10-29 07:43:57 UTC
Created attachment 451804 [details]
config.log
Created attachment 451806 [details]
dev-libs:libp11-0.4.2:20161029-043217.log
Created attachment 451808 [details]
emerge-history.txt
Created attachment 451810 [details]
environment
mtrojnar commented Oct 29, 2016 Supporting OpenSSL is complex enough. Supporting other libraries is not within goals of this project. *** Bug 658654 has been marked as a duplicate of this bug. *** *** Bug 658610 has been marked as a duplicate of this bug. *** Created attachment 567520 [details, diff]
libp11-0.4.4-libressl-2.8.3.patch
First Run attempt at a patch. Uses libp11-0.4.4 only, and LibreSSL-2.8.3
Compiles, runs Yubikey Personalization Tool (gui), looking foward to other, more rigorous testing.
Mostly works by kicking every varied openssl option back to legacy, including to some interfaces that will be deprecated in 0.5.0 - hopefully LibreSSL's 2.9.X series' compatibility enhancements will make similar work easier for then.
Thanks, but please work with upstream to merge this. We should not fork upstream against its will. (In reply to Alon Bar-Lev from comment #9) > Thanks, but please work with upstream to merge this. We should not fork > upstream against its will. Looking forward to it! Just needed to get something compatible out - v0.4.4 is listed as "stable" in the portage tree, so it seemed like a reasonable starting point. From here? Something that can be upstreamed is the goal - but that may take more time than this working/starter patch. (In reply to Alon Bar-Lev from comment #9) > Thanks, but please work with upstream to merge this. We should not fork > upstream against its will. The master branch of this library on github installs as a preliminary build for 0.4.10 - no patch needed - looking forward to seeing this in the portage tree! Waiting for this to be released. Created attachment 567826 [details, diff]
libp11-0.4.9-compat-LibreSSL-2.8.3.patch
(already upstreamed for libp11-0.4.10)
compiled on amd64, tested ok with "Yubikey Personalization Tool" gui.
most of the work was already done for us for v0.4.9 - only a slight update is needed to fix it with the latter-stable LibreSSL-2.8.3!
as LibreSSL catches up to TLS v1.3, more of our:
'if defined(LIBRESSL_VERSION_NUMBER)'
commands become
'if LIBRESSL_VERSION_NUMBER < 0x2080000L'
(For 0x2 08 03 00L as v2.8.3)
I look forward to patching with you all.
As far as I can see this[1] breaks upstream build Please ping me when fixed/merged. Thanks! [1] https://github.com/OpenSC/libp11/pull/277 version bump - 0.4.10 is live. Reworked that patch to preserve openssl functionality. builds with LibreSSL 2.9.1 or 2.8.3, with upstream v0.4.10 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3773cd14df1a2e6f493acb4405f02e8ddc2261e commit b3773cd14df1a2e6f493acb4405f02e8ddc2261e Author: Alon Bar-Lev <alonbl@gentoo.org> AuthorDate: 2019-04-25 05:11:01 +0000 Commit: Alon Bar-Lev <alonbl@gentoo.org> CommitDate: 2019-04-25 05:11:01 +0000 dev-libs/libp11: version bump Closes: https://bugs.gentoo.org/show_bug.cgi?id=598410 Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org> Package-Manager: Portage-2.3.62, Repoman-2.3.11 dev-libs/libp11/Manifest | 1 + dev-libs/libp11/libp11-0.4.10.ebuild | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) |