Summary: | x11-drivers/xf86-input-libinput-0.14.0: compile failure | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stijn Tintel <stijn+gentoo> |
Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kris, toralf, zmedico |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 559062 | ||
Attachments: |
build.log
Patch with fix as suggested by Jeremi Piotrowski |
Description
Stijn Tintel
2015-09-21 06:02:05 UTC
Created attachment 412398 [details]
build.log
*** This bug has been marked as a duplicate of bug 555284 *** This is *not* a duplicate of bug 555284, I have all the *proto packages mentioned in _that_ bug installed and _this_ bug is still present. This looks to me like an upstream bug, caused by a missing "include". The fix is adding #include <xf86.h> to `src/xf86libinput.h`. The header is part of x11-base/xorg-server. (In reply to Jeremi Piotrowski from comment #3) > This is *not* a duplicate of bug 555284, I have all the *proto packages > mentioned in _that_ bug installed and _this_ bug is still present. Same here. All packages mentioned in #555284 are installed and also still running into this issue. Versions 0.6.0, 0.12.0 and 0.13.0 previously compiled fine on this system. > > This looks to me like an upstream bug, caused by a missing "include". The > fix is adding > > #include <xf86.h> > > to `src/xf86libinput.h`. The header is part of x11-base/xorg-server. This does indeed fix the compile. Thanks! Created attachment 412512 [details, diff]
Patch with fix as suggested by Jeremi Piotrowski
(In reply to Stijn Tintel from comment #5) > Created attachment 412512 [details, diff] [details, diff] > Patch with fix as suggested by Jeremi Piotrowski This patch worked for me. The ability to reproduce this bug is dependent on the installed versions of headers. You'll be able to reproduce it only if xf86.h doesn't happen to be included indirectly via the existing includes. FYI I posted the patch on upstream mailing list: http://lists.freedesktop.org/archives/wayland-devel/2015-October/024898.html Still present in 0.15.0. *** Bug 570700 has been marked as a duplicate of this bug. *** As upstream ignored the patch so far, I added it to xf86-input-libinput-0.18.0 *** Bug 587202 has been marked as a duplicate of this bug. *** Re-opening. Like reported in bug 587202 (now marked as duplicate of this bug) the patch added by chithanh in comment #10 is only in the repository but no ebuild is applying the patch. src_prepare() was accidentally removed: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=594f3bfccf74fe7409cc563feec8329bcc69c89f https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=29d00baa21462a08ced7c5761c77974c7f43122c @mrueg please revert your change per comment 13 However as upstream's 0.19.0 includes this patch, this bug is considered fixed. |