Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 468380

Summary: eutils.eclass: prune_libtool_files() remove *.la files, which are NOT libtool archives
Product: Gentoo Linux Reporter: Sergey Popov <pinkbyte>
Component: EclassesAssignee: Michał Górny <mgorny>
Status: RESOLVED FIXED    
Severity: normal CC: base-system
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=468292
https://bugs.gentoo.org/show_bug.cgi?id=470206
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Suggested patch

Description Sergey Popov gentoo-dev 2013-05-03 09:32:42 UTC
Just as said in summary. For example, look at bug #468292. It seems that function need some additional checks for file type(probably some kind of MIME check? dunno).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-03 14:34:11 UTC
Those files are autogenerated and therefore have quite a pre-defined format. I think we could try matching them by 'shouldnotlink=' line (which the function uses anyway).
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-03 15:10:17 UTC
Created attachment 347274 [details, diff]
Suggested patch

I'll submit it to the ml after testing.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-15 19:01:49 UTC
+  15 May 2013; Michał Górny <mgorny@gentoo.org> eutils.eclass:
+  prune_libtool_files: do not remove .la files which are not libtool files.
+  Fixes bug #468380.