Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 442342

Summary: dev-perl/Data-Diver - Simple, ad-hoc access to elements of deeply nested structures
Product: Gentoo Linux Reporter: Thomas Witt <bugs>
Component: New packagesAssignee: Mikle Kolyada <zlogene>
Status: RESOLVED FIXED    
Severity: enhancement CC: devurandom, perl, pinkbyte, proxy-maint
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/~tyemq/Data-Diver-1.0101/Diver.pm
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 340353    
Attachments: Data-Diver ebuild
Data-Diver-1.01010.0.ebuild

Description Thomas Witt 2012-11-08 11:51:33 UTC
biber-1.3 depends on dev-perl/Data-Diver

Reproducible: Always
Comment 1 Thomas Witt 2012-11-08 11:52:16 UTC
Created attachment 328796 [details]
Data-Diver ebuild
Comment 2 Mikle Kolyada archtester Gentoo Infrastructure gentoo-dev Security 2013-04-01 10:15:11 UTC
@proxy-maintainers, i will take care of that.
Comment 3 Mikle Kolyada archtester Gentoo Infrastructure gentoo-dev Security 2013-04-01 10:16:23 UTC
Created attachment 343912 [details]
Data-Diver-1.01010.0.ebuild
Comment 4 Sergey Popov gentoo-dev 2013-04-03 08:30:25 UTC
+  03 Apr 2013; Sergey Popov <pinkbyte@gentoo.org> +Data-Diver-1.010.1.ebuild,
+  +metadata.xml:
+  Initial commit, wrt bug #442342. Ebuild by Mikle Kolyada, who will maintain
+  this package through proxy maintainers
Comment 5 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-05-08 02:59:58 UTC
This should have been 1.10.100 , because thats how  1.0101 normalises according to Perl version semantics. 

because 1.0101 is the same as 1.010100 , which is the same as 1.010.100 

It might not be hugley important, but it means if somebody depends on the correctly normalised form, it won't satisfy the dependency.

ie: if an upstream dependency depends on 1.01009 , which normalises as 1.10.90 , 1.10.1 will be < 1.10.90 , failing the dependency

while upstream will have intended it to be compared as 


1.10.100 < 1.10.90 

or 

1.0101  < 1.01009 

we incidentally have a tool specifically for making normalising Perl versions to Gentoo ones straight forward: dev-perl/Gentoo-PerlMod-Version


gentoo-perlmod-version.pl --oneshot  1.0101
1.10.100


gentoo-perlmod-version.pl --oneshot  1.01009
1.10.90
Comment 6 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-05-08 03:11:32 UTC
Gah. Got the directionality of my arrows wrong, which may have lead to some confusion.

To clarify, I'm not really tacking this bug on to the existing one, more, trying to give useful information to the proxy maintainer for future ebuilds for Perl

But the short of it, upstream

- x.yyyy # floating point 
         # mantisaa padded to multiple of 3 and divided by groups of three 
- x.y.z  # multipart decimal

And the easy solution to normalise things is to just pass both dependency versions and package versions to gentoo-perlmod-version.pl, with a few exceptions, namely dependencies that will intersect with packages that haven't been migrated to the new scheme yet, ie:

   >=virtual/perl-Module-Build-0.360.700

Should still be written as

   >=virtual/perl-Module-Build-0.36.07

Until that version goes out of tree.

We're in the 3rd year of transitioning, and there's still quite a few packages with the "old" un-normalised version scheme, mostly in perl-core/ and virtual/perl- , and this really aught to be documented somewhere, as its one of the more common mistakes people make. Just nobody has really gotten around to it yet it seems.
Comment 7 Larry the Git Cow gentoo-dev 2020-07-15 08:17:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9a761d810a9f58a4063faf6709d6c5d0a93c7bb6

commit 9a761d810a9f58a4063faf6709d6c5d0a93c7bb6
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2020-07-15 08:12:42 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2020-07-15 08:17:11 +0000

    profiles: package.mask dev-perl/Data-Diver
    
    Unfortunately when this package was added back in 2013, it doesn't
    seem the license information was checked. Unfortunately, no upstream
    license declarations exist, and upstream have been unresponsive as to
    even informally stating a license, and subsequently we can't have this
    in ::gentoo.
    
    Bug: https://bugs.gentoo.org/732710
    Bug: https://bugs.gentoo.org/442342
    Bug: https://rt.cpan.org/Ticket/Display.html?id=82815
    
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2020-08-06 15:39:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cda99836a0fa504805c7c7fe3d12a093a726dc92

commit cda99836a0fa504805c7c7fe3d12a093a726dc92
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2020-08-06 15:34:02 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2020-08-06 15:35:45 +0000

    dev-perl/Data-Diver: -r bump for license correction
    
    Upstream has specified this may be used under the Unlicense
    
    Reference: https://web.archive.org/web/20200806152714/https://github.com/TyeMcQueen/data-diver/issues/5
    Bug: https://bugs.gentoo.org/732710
    Bug: https://bugs.gentoo.org/442342
    Bug: https://rt.cpan.org/Ticket/Display.html?id=82815
    Bug: https://github.com/TyeMcQueen/data-diver/issues/5
    Package-Manager: Portage-2.3.103, Repoman-2.3.22
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 dev-perl/Data-Diver/Data-Diver-1.10.100-r2.ebuild | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=38221edf246faa51cfc3c52a03230acd7d5887df

commit 38221edf246faa51cfc3c52a03230acd7d5887df
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2020-08-06 15:24:32 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2020-08-06 15:35:41 +0000

    profiles/: Unmask dev-perl/Data-Diver
    
    Upstream has advised us that we may use this under "Unlicense" terms
    
    Reference: https://web.archive.org/web/20200806152714/https://github.com/TyeMcQueen/data-diver/issues/5
    Bug: https://bugs.gentoo.org/732710
    Bug: https://bugs.gentoo.org/442342
    Bug: https://rt.cpan.org/Ticket/Display.html?id=82815
    Bug: https://github.com/TyeMcQueen/data-diver/issues/5
    
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 profiles/package.mask | 6 ------
 1 file changed, 6 deletions(-)