Summary: | net-dialup/ppp: some elog messages should only be shown for the first install | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | poletti.marco |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | base-system, pacho |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 440214 |
Description
poletti.marco
2012-10-31 10:58:37 UTC
(In reply to comment #0) [...] > * If the following test report contains a missing kernel configuration > option that you need, > * you should reconfigure and rebuild your kernel before running pppd. [...] About this message, if that is true, shouldn't ebuild die when that such important options are not complaint? Otherwise, people could break "ppp" if they cannot rebuild kernel just after building ppp. For this, ebuild should simply drop "~" from checks. Also, probably this checks should be done at pkg_pretend instead of pkg_postinst phase. I guess that is because you can build it on a system different than the one finally using it. Then, I guess the message can be keep and use readme.gentoo.eclass if you want ;) I think the following lines should be dropped: ewarn "If the following test report contains a missing kernel configuration option that you need," ewarn "you should reconfigure and rebuild your kernel before running pppd." And ebuild should simply rely on warnings coming from the linux-info eclass as most other packages do The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=480ab1f451094ad901c1f2658daa94d26967109d commit 480ab1f451094ad901c1f2658daa94d26967109d Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2023-05-27 22:59:42 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2023-05-27 23:01:40 +0000 net-dialup/ppp: move kernel checks to pkg_setup Also drop message about pon/poff/plog. Closes: https://bugs.gentoo.org/440424 Signed-off-by: Mike Gilbert <floppym@gentoo.org> net-dialup/ppp/ppp-2.5.0-r2.ebuild | 54 ++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 31 deletions(-) |