Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 440424 - net-dialup/ppp: some elog messages should only be shown for the first install
Summary: net-dialup/ppp: some elog messages should only be shown for the first install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: first-time-messages
  Show dependency tree
 
Reported: 2012-10-31 10:58 UTC by poletti.marco
Modified: 2023-05-27 23:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description poletti.marco 2012-10-31 10:58:37 UTC
Disclaimer: this bug has been filed in a semi-automated manner.

When emerging the package net-dialup/ppp-2.4.5-r1, the following elog messages are displayed:

 * If the following test report contains a missing kernel configuration option that you need,
 * you should reconfigure and rebuild your kernel before running pppd.
 * Pon, poff and plog scripts have been supplied for experienced users.
 * Users needing particular scripts (ssh,rsh,etc.) should check out the
 * /usr/share/doc/ppp-2.4.5-r1/scripts directory.

Such messages should only be displayed when the package is a new install.
These situations can be checked in the ebuild as follows:

if ! has_version 'net-dialup/ppp'; then

See the tracker bug 440214 for more details.
Comment 1 Pacho Ramos gentoo-dev 2012-12-02 19:19:02 UTC
(In reply to comment #0)
[...]
>  * If the following test report contains a missing kernel configuration
> option that you need,
>  * you should reconfigure and rebuild your kernel before running pppd.
[...]

About this message, if that is true, shouldn't ebuild die when that such important options are not complaint? Otherwise, people could break "ppp" if they cannot rebuild kernel just after building ppp. For this, ebuild should simply drop "~" from checks.

Also, probably this checks should be done at pkg_pretend instead of pkg_postinst phase.
Comment 2 Pacho Ramos gentoo-dev 2014-05-27 19:55:18 UTC
I guess that is because you can build it on a system different than the one finally using it. Then, I guess the message can be keep and use readme.gentoo.eclass if you want ;)
Comment 3 Pacho Ramos gentoo-dev 2023-05-27 21:27:33 UTC
I think the following lines should be dropped:
                ewarn "If the following test report contains a missing kernel configuration option that you need,"
                ewarn "you should reconfigure and rebuild your kernel before running pppd."


And ebuild should simply rely on warnings coming from the linux-info eclass as most other packages do
Comment 4 Larry the Git Cow gentoo-dev 2023-05-27 23:02:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=480ab1f451094ad901c1f2658daa94d26967109d

commit 480ab1f451094ad901c1f2658daa94d26967109d
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-05-27 22:59:42 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-05-27 23:01:40 +0000

    net-dialup/ppp: move kernel checks to pkg_setup
    
    Also drop message about pon/poff/plog.
    
    Closes: https://bugs.gentoo.org/440424
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-dialup/ppp/ppp-2.5.0-r2.ebuild | 54 ++++++++++++++++----------------------
 1 file changed, 23 insertions(+), 31 deletions(-)