Summary: | Please add a possibility of setting repository name in layout.conf/repos.conf | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Michał Górny <mgorny> |
Component: | Enhancement/Feature Requests | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | esigra, pms |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 240187, 462382 |
Description
Michał Górny
2012-08-31 18:47:07 UTC
Zac, ping. Could we do this, please? I need this for local gx86 checkout. Otherwise, I have to make sure not to commit changed repo_name every time I commit in profiles... Yeah, it's definitely doable. However, since PMS says profiles/repo_name is required, we should hide it behind a profile-formats value (like bug #414961). I think if layout.conf would just override the profiles value, it'd be fine as-is. (In reply to comment #3) > I think if layout.conf would just override the profiles value, it'd be fine > as-is. I'd avoid that route frankly. profiles/repo_name was a bad notion forced in at the time; just set a format marker for the repository in layout.conf and store the name there- no fallback machinery. Fallback just makes things a PITA. (In reply to comment #4) > (In reply to comment #3) > > I think if layout.conf would just override the profiles value, it'd be fine > > as-is. > > I'd avoid that route frankly. profiles/repo_name was a bad notion forced in > at the time; just set a format marker for the repository in layout.conf and > store the name there- no fallback machinery. Fallback just makes things a > PITA. I can leave with that as long as it won't make repoman do something weird when committing to the repo :P. (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > I think if layout.conf would just override the profiles value, it'd be fine > > > as-is. > > > > I'd avoid that route frankly. profiles/repo_name was a bad notion forced in > > at the time; just set a format marker for the repository in layout.conf and > > store the name there- no fallback machinery. Fallback just makes things a > > PITA. > > I can leave with that as long as it won't make repoman do something weird > when committing to the repo :P. Well, if you were to write the patch, you could ensure it behaved. Hint hint. ;) This is fixed in git: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=da471fa9a131f3bb99941ef315f187b8772a3d7f This is fixed in 2.1.11.60 and 2.2.0_alpha171. (In reply to comment #7) missing documentation in the man page though (In reply to comment #9) > (In reply to comment #7) > > missing documentation in the man page though Fixed: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e0a1cd8432b4c528fb47a7229002c5a3b468039e |