| Summary: | net-dialup/rp-pppoe kernel-mode PPPoE support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Oleg Gawriloff <barzog> |
| Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adrian.sandu, jaco, jer, pacho, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/23126 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 868906 | ||
| Bug Blocks: | |||
| Attachments: |
emerge --info output
compile log |
||
|
Description
Oleg Gawriloff
2011-04-26 14:39:07 UTC
1) Please attach the entire build log to this bug report. 2) Please post your `emerge --info' output too. Created attachment 271265 [details]
emerge --info output
Created attachment 271267 [details]
compile log
*** Bug 507458 has been marked as a duplicate of this bug. *** +*rp-pppoe-3.11-r3 (07 Jan 2015) + + 07 Jan 2015; Pacho Ramos <pacho@gentoo.org> +files/rp-pppoe-3.11-kmode.patch, + +rp-pppoe-3.11-r3.ebuild, -rp-pppoe-3.10-r1.ebuild, -rp-pppoe-3.11-r1.ebuild: + Don't hardcode ppp detection at some phases and try to autodetect on others, + fix kmode detection using ArchLinux approach (#364941), rename X USE flag to + 'tk' (#349014), drop old + Does it work ok for you? Currently net-dialup/rp-pppoe does not build kernel plugin but only installs symlink to very old plugin which comes bundled with net-dialup/ppp. Can you fix this? With 3.13: checking for Linux 2.4.X kernel-mode PPPoE support... yes I only found this because it triggered automatic loading of the module in question right from the sandbox: [85331.663632][T32401] PPP generic driver version 2.4.2 [85331.663632][T32401] PPP generic driver version 2.4.2 [85331.871619][T32401] NET: Registered protocol family 24 [85331.871619][T32401] NET: Registered protocol family 24 From ppp-2.4.9 README: * The rp-pppoe plugin has been renamed to pppoe, to distinguish it from the upstream rp-pppoe code. Its options have changed names, but the old names are kept as aliases. Since ppp-2.4.9 plugin renamed to pppoe.so I'm working on a PR for https://bugs.gentoo.org/715396. And found this. For the other bug, a simple fix is a one-line change to the Makefile to update PLUGIN_PATH=pppoe.so (and then update the ebuild to not install ANYTHING into /etc/ppp/plugins. Binaries IMHO doesn't belong there anyway. However, based on this bug there seems to be a need to use the plugin from rp-pppoe. There are two things here: Using the ppp plugin means we don't need to actually remerge rp-pppoe when ppp gets remerged (it's small and quick though). I will need to test, but I believe ppp can be bumped to purely RDEPEND. If we use the rp-pppoe.so from this package, then we do need to remerge. ppp remains in RDEPEND as well as DEPEND (as current, should be :=). Currently it's := purely to correctly update the symbolic link (which is now broken anyway). This is currently a compile-time option for rp-pppoe, and looking at the ML I doubt we will get support in changing this from upstream side. I don't mind a patch if there is demand for it, but my suggestion is to add a USE flag that selects between using the pppoe plugin from ppp package, and the rp-pppoe plugin from rp-pppoe package. For the case where we use the rp-pppoe plugin, I also recommend we install into the correct plugins folder (/usr/libX/pppd/${ppp-PV}/) rather than /etc/ppp/plugins. If this is not desirable I recommend just using the one from ppp as per current, and just adjusting the build to work out of the box rather than being broken out of the box. I've already looked into the required, so happy to do a PR, just need guidance on what would be preferred, my recommendations above. Just so all is clear: 3.15-r1 will use the rp-pppoe.so plugin (which ships with rp-pppoe package). To vary this will require some C code changes, which I'm happy to do, if there is demand. As you can deduce from time of posting previous comment till now - it's been somewhat busy on this end. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d413bc84e352fd761aabeadd7fe5a2412fd2b9bf commit d413bc84e352fd761aabeadd7fe5a2412fd2b9bf Author: Jaco Kroon <jaco@uls.co.za> AuthorDate: 2021-11-30 12:12:46 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-12-01 21:29:15 +0000 net-dialup/rp-pppoe: revision bump to fix bugs. Closes: https://bugs.gentoo.org/715396 Closes: https://bugs.gentoo.org/364941 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Jaco Kroon <jaco@uls.co.za> Closes: https://github.com/gentoo/gentoo/pull/23126 Signed-off-by: Sam James <sam@gentoo.org> net-dialup/rp-pppoe/metadata.xml | 2 +- net-dialup/rp-pppoe/rp-pppoe-3.15-r1.ebuild | 89 +++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+), 1 deletion(-) |
