Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715396 - net-dialup/rp-pppoe failed plugins symlink
Summary: net-dialup/rp-pppoe failed plugins symlink
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 868906
Blocks:
  Show dependency tree
 
Reported: 2020-03-30 07:53 UTC by Jaco Kroon
Modified: 2022-09-06 19:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2020-03-30 07:53:53 UTC
This was tested with version 3.12-r1, I'm not sure if this is sorted out with version 3.13.

# equery belongs /etc/ppp/plugins 
 * Searching for /etc/ppp/plugins ... 
net-dialup/rp-pppoe-3.12-r1 (/etc/ppp/plugins)

So this isn't a native ppp folder, rp-pppoe creates it.

In then installs a README file with:

# Directory created by rp-pppoe for kernel-mode plugin

With this symlink:

rp-pppoe.so -> /usr/lib64/pppd/2.4.8/rp-pppoe.so

The issue is I had to manually update that symlink, because this is what's installed by the package:

# equery files rp-pppoe
 * Searching for rp-pppoe ...
 * Contents of net-dialup/rp-pppoe-3.12-r1:
...
/etc/ppp/plugins/rp-pppoe.so -> /usr/lib/pppd/2.4.7/rp-pppoe.so

... this stems from the merge order:

# genlop -l | grep ppp
     Sat Apr  6 17:59:20 2019 >>> net-dialup/ppp-2.4.7-r7
     Sat Apr  6 17:59:31 2019 >>> net-dialup/rp-pppoe-3.12-r1
     Mon Sep 30 13:25:35 2019 >>> net-dialup/ppp-2.4.7-r7
     Sun Mar 29 09:58:08 2020 >>> net-dialup/ppp-2.4.8

And boom goes the symlink.  If rp-pppoe used "plugin rp-pppoe" this would not be a problem, but since it does "plugin /etc/ppp/plugins/rp-pppoe.so" this does not work so well.

I've seen hints re rp-pppoe building it's own plugin.  But I've not done proper research.  As such there are three possibilities I think:

1.  rp-pppoe should build it's own plugin into this folder.
2.  rp-pppoe should be rebuild on ppp update in order to update it's symlink.
3.  rp-pppoe should pass "plugin rp-pppoe.so" unless it does (1).

I personally prefer option 3.  Don't have time right now to patch it this way .. and would like some feedback on the ideas.

Reproducible: Always
Comment 1 Jaco Kroon 2021-09-20 14:17:48 UTC
Bumped into this again just now.

Symlink no longer gets installed at all.

Recommendation at this stage:  patch rp-pppoe to just pass "plugin pppoe" instead of the full path.  Will create PR momentarily.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-09-20 14:24:29 UTC
(In reply to Jaco Kroon from comment #1)
> Will create PR momentarily.

Thanks
Comment 3 Larry the Git Cow gentoo-dev 2021-12-01 21:29:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d413bc84e352fd761aabeadd7fe5a2412fd2b9bf

commit d413bc84e352fd761aabeadd7fe5a2412fd2b9bf
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2021-11-30 12:12:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-01 21:29:15 +0000

    net-dialup/rp-pppoe: revision bump to fix bugs.
    
    Closes: https://bugs.gentoo.org/715396
    Closes: https://bugs.gentoo.org/364941
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/23126
    Signed-off-by: Sam James <sam@gentoo.org>

 net-dialup/rp-pppoe/metadata.xml            |  2 +-
 net-dialup/rp-pppoe/rp-pppoe-3.15-r1.ebuild | 89 +++++++++++++++++++++++++++++
 2 files changed, 90 insertions(+), 1 deletion(-)