Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 337745

Summary: games-action/barrage _FORTIFY_SOURCE indicates presence of overflow
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: [OLD] GamesAssignee: Gentoo Games <games>
Severity: major CC: hardened
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 259417    
Attachments: Build log
Patch to barrage-1.0.2-r1 to increase size of menu member name[]

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-17 02:43:52 UTC
You're receiving this bug because the package in Summary has produced _FORTIFY_SOURCE related warnings indicating the presence of a sure overflow in a static buffer.

Even though this is not always an indication of a security problem it might even be. So please check this out ASAP.

By the way, _FORTIFY_SOURCE is disabled when you disable optimisation, so don't try finding out the cause using -O0.

Your friendly neighborhood tinderboxer
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-17 02:44:03 UTC
Created attachment 247683 [details]
Build log
Comment 2 Kevin Pyle 2010-09-18 02:26:14 UTC
Created attachment 247745 [details, diff]
Patch to barrage-1.0.2-r1 to increase size of menu member name[]

Upstream uses a hardcoded size to snprintf and subscripts the member name as though it were [24], but declared it to be [20].  This caused a "guaranteed overflow" warning and an "array subscript above bounds" warning.  This patch increases the size of name[] to 24 so that the specified limits are now valid.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2010-09-18 04:08:37 UTC
fixed in portage.  thanks for the patch.