Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 314929

Summary: qt4-r2.eclass has broken eqmake4. qmake_args should be quoted
Product: Gentoo Linux Reporter: Sergey Ilinykh <rion4ik>
Component: EclassesAssignee: Qt Bug Alias <qt>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 311481    

Description Sergey Ilinykh 2010-04-13 05:26:31 UTC
eqmake4 must quote ("${qmake_args}") when executing qmake.
w/o qouting its impossible execute qmake with argument like var="var var2 var3" (space separated parameters in one var).

typical example which fails: eqmake4 project.pro var="var var2 var3"

for more details see http://bugs.gentoo.org/show_bug.cgi?id=311481
i created new bug report since no one wants to fix this by report in the 311481

Reproducible: Always
Comment 1 Jonathan Callen (RETIRED) gentoo-dev 2010-04-15 06:54:39 UTC
The suggested fix in comment #0 would break when passing any argument other than a .pro file. I instead fixed this by making the local qmake_args variable an array, which allows preservation of quoting.
Comment 2 Sergey Ilinykh 2010-04-15 09:45:04 UTC
afaik portage-2.1.6 doesn't work properly with arrays.
but thanks
Comment 3 Jonathan Callen (RETIRED) gentoo-dev 2010-04-16 01:25:00 UTC
(In reply to comment #2)
> afaik portage-2.1.6 doesn't work properly with arrays.
> but thanks
> 

All versions of portage work just fine with arrays that are declared local to a function - it's only arrays that cross the function boundary that can cause issues.