Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 314929 - qt4-r2.eclass has broken eqmake4. qmake_args should be quoted
Summary: qt4-r2.eclass has broken eqmake4. qmake_args should be quoted
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qt4eclass
  Show dependency tree
 
Reported: 2010-04-13 05:26 UTC by Sergey Ilinykh
Modified: 2010-04-16 01:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Ilinykh 2010-04-13 05:26:31 UTC
eqmake4 must quote ("${qmake_args}") when executing qmake.
w/o qouting its impossible execute qmake with argument like var="var var2 var3" (space separated parameters in one var).

typical example which fails: eqmake4 project.pro var="var var2 var3"

for more details see http://bugs.gentoo.org/show_bug.cgi?id=311481
i created new bug report since no one wants to fix this by report in the 311481

Reproducible: Always
Comment 1 Jonathan Callen (RETIRED) gentoo-dev 2010-04-15 06:54:39 UTC
The suggested fix in comment #0 would break when passing any argument other than a .pro file. I instead fixed this by making the local qmake_args variable an array, which allows preservation of quoting.
Comment 2 Sergey Ilinykh 2010-04-15 09:45:04 UTC
afaik portage-2.1.6 doesn't work properly with arrays.
but thanks
Comment 3 Jonathan Callen (RETIRED) gentoo-dev 2010-04-16 01:25:00 UTC
(In reply to comment #2)
> afaik portage-2.1.6 doesn't work properly with arrays.
> but thanks
> 

All versions of portage work just fine with arrays that are declared local to a function - it's only arrays that cross the function boundary that can cause issues.