Summary: | News item 2009-07-12-xorg-74-alpha shows up on other archs | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Allen Brooker (AllenJB) <gentoo-bugs> |
Component: | Core | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | betelgeuse, billie, dhp_gentoo, klausman, ulm |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 210077, 288499 | ||
Attachments: |
completely untested patch
somehow I think the patch will be more useful than my marked up news.py ;) old patch without messed up tabbing |
Description
Allen Brooker (AllenJB)
2009-07-13 08:13:23 UTC
I asked about the logical operators between Display-If-X and I understood that the various lines with constant X are ORed and those sets of OR'ed lines are then AND'ed. The docs say so and -dev@ consensus was that it should work that way. So in my case this should have been: ( profile=default-linux/alpha|| profile=default/linux/alpha )&& installed=x11-base/xorg-server But apparently, it isn't so either the code has a bug or the docs are wrong. Reassigning to portage, since filtering of items is the package manager's task. (In reply to comment #1) > I asked about the logical operators between Display-If-X and I understood that > the various lines with constant X are ORed and those sets of OR'ed lines are > then AND'ed. The docs say so and -dev@ consensus was that it should work that > way. > > So in my case this should have been: > ( > profile=default-linux/alpha|| > profile=default/linux/alpha > )&& > installed=x11-base/xorg-server > > But apparently, it isn't so either the code has a bug or the docs are wrong. > In portage, all the restrictions are OR'd. <code from="news.py"> for restriction in self.restrictions: if restriction.checkRestriction(**kwargs): return True </code> Created attachment 198248 [details, diff]
completely untested patch
I hate tabs; a lot.
Created attachment 198250 [details, diff]
somehow I think the patch will be more useful than my marked up news.py ;)
I still hate tabs.
Created attachment 198251 [details, diff]
old patch without messed up tabbing
i still hate tabs; but figured I'd fix em.
(In reply to comment #6) > Created an attachment (id=198251) [edit] Thanks, this is in svn r14081. This is fixed in 2.2_rc39. This is fixed in 2.1.7. *** Bug 301140 has been marked as a duplicate of this bug. *** |