| Summary: | Add QA check for respecting LDFLAGS | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Core | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | Keywords: | InVCS |
| Priority: | High | ||
| Version: | 2.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 331933, 210077, 216231 | ||
| Attachments: | Patch | ||
Created attachment 161448 [details, diff]
Patch
This is great, thanks! how about using
if [[ " ${LDFLAGS} " == *" --hash-style=gnu "* ]] && ...
instead such that you're sure to only match hash-style "gnu"?
(In reply to comment #3) > how about using > if [[ " ${LDFLAGS} " == *" --hash-style=gnu "* ]] && ... > instead such that you're sure to only match hash-style "gnu"? It usually wouldn't match this flag. This is fixed in 2.2_rc4. |
Portage should contain QA check for respecting LDFLAGS. This check should be run when LDFLAGS contain --hash-style=gnu, because files built with this flag don't contain .hash sections. The check should be disabled for packages with ${PN}=*-bin. The QA_DT_HASH variable can be set in ebuilds to avoid false positives.