Summary: | Fix for Gentoo themes in gdm-2.8.0.7 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Wiktor Wandachowicz <siryes> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | d2_racing |
Priority: | Highest | ||
Version: | 2006.0 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://shots.osdir.com/slideshows/slideshow.php?release=588&slide=4 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 119872 | ||
Attachments: |
gentoo-gdm-theme-r2.patch
gdm-2.8.0.7.ebuild.diff |
Description
Wiktor Wandachowicz
2006-03-04 02:27:51 UTC
Created attachment 81276 [details, diff]
gentoo-gdm-theme-r2.patch
This patch makes the two Gentoo gdm themes, gentoo-emergence and gentoo-cow,
compatible with the rest of gdm themes. Essentially, it removes all the <text>
tags in favor of <stock> tags used by newer gdm.
Created attachment 81277 [details, diff]
gdm-2.8.0.7.ebuild.diff
Proof-of-concept patch against gdm-2.8.0.7.ebuild file.
It shouldn't be put in the portage, obviously, as it contains an epatch
invocation and requires the presence of files/gentoo-gdm-theme-r2.patch
Instead, an updated gdm ebuild that depends on the updated
gentoo-gdm-theme-r3.tar.bz2 file should be created.
Side note:
After using the previous patch the gentoo-emergence.xml and gentoo-cow.xml
files dropped down in size from 35kB to 8kB and from 20kB to 7kB respectively.
I think this is a good sign. :-)
Just one more comment. The fonts in gentoo-emergence were once "Sans 12". Then, around half of a year ago, they were changed to "Sans 14". IMO, this was a mistake, since it made several translated texts to reach over the right edge of the screen -> aesthetically unpleasant. I suppose this was done in order to "magnify" the fonts for higher resolutions, like 1600x1200. But in 1024x768 the 14pt Sans font is just too big... The patch I've proposed reverts to the "Sans 12" - exactly like it is in the gdm's circles theme. And the latter is given as an exemplary theme, well translated and well designed. So, it's up to you. Please decide. HTH, I'm sorry to CC all of you, but this bug (#124920) has been left unseen for almost two weeks already and I'd like someone to answer. The fix is provided, so all that's left is to put a new version of gentoo-gdm-theme-r*.tar.bz2 in portage. If it qualifies, of course. While stablizing Gnome 2.14, why not fix this long standing issue with translation of the Gentoo GDM themes at the same time? Friendly, Wiktor Wandachowicz (In reply to comment #4) > I'm sorry to CC all of you, but this bug (#124920) has been left unseen for > almost two weeks already and I'd like someone to answer. The fix is provided, > so all that's left is to put a new version of gentoo-gdm-theme-r*.tar.bz2 in > portage. If it qualifies, of course. All those people are either on gnome alias already, or don't have anything to do w/ gnome (like me). No point in spamming them. (In reply to comment #5) > All those people are either on gnome alias already, or don't have anything to > do w/ gnome (like me). No point in spamming them. I apologize. I didn't know that gnome alias does the job. I just took the nicknames from the ebuild and discussions in the aforementioned bugs. Once again I apologize. Look, for me with my personal overlay it's not a problem. It's just all the other Gentoo users who don't have enough luck to know about the issue. I took my time and I analyzed the problem. IMO I've found a clean solution. All that's left is to take 20 minutes of your precious time and apply the fix. Alternatively you can of course close the bug, but it wouldn't remove the problem. Is the following other themes' .xml structure and using <stock type=""> labels considered bad? Is it really better to keep the translated text inside the .xml instead of using the unified/translated gdm's .po files? Judge by yourself, but then keep it proffessional and don't complain that something is wrong, like (quoting foser): " the gentoo themes are broken translation wise, thats why they're not defaulted to anymore. " http://bugs.gentoo.org/show_bug.cgi?id=96585#c3 I don't want to delve deeper than that, but I felt insulted once by that answer and despite this I still offered help (but I was ignored): http://bugs.gentoo.org/show_bug.cgi?id=104123#c8 Now it's my third and last attempt, with analysis, solution, description and proper patches (yes, I've finally got to know how to make them right). Just click any of "Diff" links in the patch table to see what I mean. The issue is over 9 months old today. Maybe something should be born from it at last? ;-D looks good to me, lets give it a whirl. *** Bug 104123 has been marked as a duplicate of this bug. *** updated gentoo-gdm-themes to r3 with the (fixed) patch proposed here. 2.14.1 now uses it. To be fair, this is the first time the solution is acceptable, so I would read the other reports in their context instead of misquoting me. Thanks for sticking with it and proposing this fix. (In reply to comment #9) > To be fair, this is the first time the solution is acceptable, Exactly. > so I would read > the other reports in their context instead of misquoting me. Point taken. :) > Thanks for sticking with it and proposing this fix. It's always good to see a nice "thanks" from a Gentoo developer. Thanks for putting the updated version in Portage! |